Hub lists fail to cache on Linux

[Steven Sheehy]

Thrown: FileException: No such file or directory: /home/steven/.dc++/HubLists/http_/hublist.openhublist.org/hublist.xml.bz2

This file cannot be created because it contains '/' in the filename and the sub directories "http_" and "hublist.openhublist.org" do not exist to create hublist.xml.bz2 in. The hub list URL needs to be normalized to a form suitable for both Windows and Linux. For example:

http://hublist.openhublist.org/hublist.xml.bz2 -> hublist.openhublist.org#hublist.xml.bz2

Or Util::validateFileName() needs to be split into Util::validateFilePath() and Util::validateFileName() so that validateFileName() can replace PATH_SEPARATORs in the name. This will allow the hublist to be saved as "http__hublist.openhublist.org_hublist.xml.bz2".

[Fredrik Ullner (ullner)]

The attached patch should replace the path separator with an underscore.

(I should note that when testing on Windows, just downloading a hublist, DC++ (prepatch) would create the file with underscore already and not with a directory.)

[poy (poy)]

that solution would flatten any file path. the issue here is that validateFileName is used for both paths (directories + separators + files) and plain files, so it can't differenciate.

Steven's suggested split seems to be the best way forward.

[maksis (maksis)]

https://github.com/airdcpp/airgit/commit/d101c6a81ba7913a10867aa6a2063e50cb1abf09

[poy (poy)]

the changeset linked above is perfect - can you make a patch for DC++?

[Fredrik Ullner (ullner)]

Apply .diff or .patch to the end of a Github URL and you'll get a patch:
https://github.com/airdcpp/airgit/commit/d101c6a81ba7913a10867aa6a2063e50cb1abf09.diff
 (I only found this out a yesterday or so.)

[poy (poy)]

that's cool, but a patch tailored to DC++ would be preferable. one should in particular ensure we don't have more calls to the previous function that have to be renamed.

[Fredrik Ullner (ullner)]

This is diff targetting DC++, based on the same principle as AirDC++.

[poy (poy)]

looks fine; feel free to push.

[poy (poy)]

Fixed in DC++ 0.840.

[poy (poy)]

the current patch is leading to unwanted log file path changes (eg hub.example.com.log instead of hub_example_com.log). reverted in rev 7423e91f22ae.