adc search

Bug #306209 reported by Gabberworld
4
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Low
Unassigned

Bug Description

in ADC protocol there is typed that passive user should get 5 search result, but i get 10 when i'm passive.

Revision history for this message
Sulan (sulan80) wrote :

In: SearchManager::respond
ShareManager::getInstance()->search(results, adc.getParameters(), 10);
I think it should be:
 ShareManager::getInstance()->search(results, adc.getParameters(), isUdpActive ? 5:10);

However it says "Should" and not "Must".

Revision history for this message
Pietry (pietry) wrote :

Shouldn;t be isUdpActive ? 10:5
eg 10 for active 5 for passive

Revision history for this message
Sulan (sulan80) wrote :

Yes you are right

Revision history for this message
poy (poy) wrote :

nice.

you should put the critical section in its own block before calling SearchManager though.

Revision history for this message
Sulan (sulan80) wrote :

Ok changed it

poy (poy)
Changed in dcplusplus:
status: New → Fix Committed
Pietry (pietry)
Changed in dcplusplus:
importance: Undecided → Low
eMTee (realprogger)
Changed in dcplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.