TigerHash.cpp compile fails on ppc
Bug #268353 reported by
Edward Sheldrake
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
DC++ |
Fix Released
|
Low
|
Unassigned |
Bug Description
HASH_SIZE is undefined inside the #ifdef TIGER_BIG_ENDIAN code.
It needs replacing with BYTES.
Operating system is Fedora 9, DC++ version was the 0.707 source and it's still in 0.708.
This affects LinuxDC++ and also dclib/valknut since TigerHash.cpp is used there too.
Unfortunately I can't even get a simple answer for if ppc is even big endian (it depends on the OS?), there is a gentoo bug about this suggesting it isn't but then they also managed to incorrectly replace HASH_SIZE with BLOCK_SIZE.
Related branches
Changed in dcplusplus: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
How can HASH_SIZE be undefined? It is a class enum in TigerHash.h and its declaration is not dependent on any #ifdef, thus it should be available everywhere. Can you paste the compiler error you receive and provide a link to the gentoo bug? Also, I believe PowerPC is bi-endian, but does most of its processing in big-endian.