Make automatic source additon and automatch queue independent on autosearch

Bug #257225 reported by eMTee
2
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Low
Unassigned

Bug Description

Automatic source additon from searches and automatch queue is available only when 'Automatically search for alternative download locations' is enabled atm.
Those who don't like autosearch or can't use it because of longer min. search intervals on some hubs are not able to use these functions.
The attatched patch would
- extend automatch queue function to all searches
- add a new option for adding sources from manual search hits to the queue automatically even if autosearch is disabled.

Revision history for this message
eMTee (realprogger) wrote :
Changed in dcplusplus:
importance: Undecided → Low
Revision history for this message
poy (poy) wrote :

the patch is ok, but i don't think we need a 3rd option there; the 2 current are already hard enough to understand for the average user...
"- add a new option for adding sources from manual search hits to the queue automatically even if autosearch is disabled." > maybe it's just me, but i find it completely natural to always do that, and that it shouldn't be optional. is there any case where one would want that option disabled?

Revision history for this message
eMTee (realprogger) wrote :

>is there any case where one would want that option disabled
I can't name any case as well, just thought the option would be good for those who always complain when some long term behaviour suddenly changes in DC++ :) Maybe carefully selected default values for this 3 option would satisfy the average users' needs...

Revision history for this message
poy (poy) wrote :

actually, matching each search result with large queues could consume some resources, so this could justify this option's existence.
it adds a new string so you're gonna have to wait for 0.708 to be released...

Revision history for this message
Jacek Sieka (arnetheduck) wrote :

Actually, I think this should always be on now that we have multisource downloads...in an ideal world, it would also always match file lists using browse file list (adc only of course) for the dir where it found the file...

Changed in dcplusplus:
status: New → In Progress
Changed in dcplusplus:
status: In Progress → Fix Committed
Revision history for this message
Big Muscle (bigmuscle) wrote :

just a small comment - browse filelist works also in nmdc by using $ADCGET with "list" param ;-)

MikeJJ (mrmikejj)
Changed in dcplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.