Double click doesn't work on search combo box

Bug #241995 reported by Jota.Ce
2
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Medium
Unassigned

Bug Description

That mouse even allowed you to select a full word (and not the entire text) in combo box.

That was the natural component behaviour, so it might be unfixable.

Thanks Jacek for your tips and help.

Revision history for this message
Jota.Ce (psidtg) wrote :

Oh, i forgot to tag this one as [Wishlist]

Revision history for this message
eMTee (realprogger) wrote :

It does not work on other text input fields either. I also miss it sometimes mostly in the mainchat / PM windows :)

Changed in dcplusplus:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
cologic (cologic) wrote :

I guess this has probably already been investigated by someone else, but in case...

The issue appears to be that under WTL the mouse handlers could indicate whether they handled a message; otherwise that message would be passed through to a pre-existing handler. This mechanism is now effectively gone in dwt, because the event handlers return void.

This looks like it might have to be a sweeping change -
 bool operator()(const MSG& msg, LRESULT& ret) const {
  f((*C)(msg));
  ret = value;
  return handled;
 }
in dwt/include/dwt/Dispatchers.h, for example, is why currently the handlers can be void, but also why they can't signal that they have not handled a message even if given a non-void return value. I'm not sure if C++ without metaprogramming tricks can easily dispatch based on return value of f - if it can't, then it would seem that for any given Aspect* handler (AspectMouse in this case) it'd then be necessary to go through and make every AspectMouse event handler return bool rather than void, even those for which one might not directly care about their return value.

poy (poy)
Changed in dcplusplus:
importance: Wishlist → Medium
status: Confirmed → Fix Committed
eMTee (realprogger)
Changed in dcplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.