0.70x versions do not send results for certain searches

Bug #237682 reported by eMTee
2
Affects Status Importance Assigned to Milestone
DC++
Fix Released
High
Unassigned

Bug Description

From Answers : I belong to a small private Hub. Users connected with DC++ 0.706 will not show results when any other user searches. We can get their file list and know they have a specific file etc., but when you search for those files nothing is returned from that user. I checked users with 0.705 and the problem is not there. Is there a fix or should I have the users roll back to 0.705?

With some tests it turned out that probalby all 0.70x versions have a bug that prevents sending search results in most cases when searching for files or directories which are in
word1 word2 word3 wordx.ext or word1_word2_word3_wordx.ext
format AND the search term contains more than one of these words (or the full filename).
It works though if you search ONLY for the 1st word.

eMTee (realprogger)
Changed in dcplusplus:
importance: Undecided → Medium
Revision history for this message
poy (poy) wrote :

confirmed; during these tests it appeared that if a file is named something like "a b.ext", then that file will show up when searching for "a" but not when searching for "b".

reverting the changes made on the file dcpp/BloomFilter.h in revision 922 fixes the problem; attached is a patch that can be applied to the current repo to revert the file in question.
it would be better to fix the current function instead of having to change it back to old methods, but the math done there is beyond my competence...

Changed in dcplusplus:
status: New → In Progress
Revision history for this message
Jacek Sieka (arnetheduck) wrote :

now there's a better fix, nothing to do with maths =)

Changed in dcplusplus:
importance: Medium → High
status: In Progress → Fix Committed
MikeJJ (mrmikejj)
Changed in dcplusplus:
status: Fix Committed → Fix Released
john (johnranjith)
Changed in dcplusplus:
status: Fix Released → New
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.