[0.706] Can't decide what's finished

[Szabolcs Molnár]

In the Finished Downloads window you won't only see the "finished downloads" but you can see any files wich has any finished segments. There's no problem with that, but you can't see the difference between the files really finished and the ones in progress. I recommend you to indicate somehow the finished files.
Moreover, the item Open/View in the right-click menu of an unifnished file should be deactivated.

[Szabolcs Molnár (fleet)]

It's not a duplicated bug.

bug #208615 states "Multiple instances".. I said _nothing_ about multiple instances. If you were noticed, I reported it in 0.706 which does not have any issues with multiple instances or whatever.

The problem is that in the Finished Downloads' frame you can't see the difference between the fully downloaded files and the partly downloaded files. Please remove the duplicate mark.

[eMTee (realprogger)]

Maybe a new percentage column or a percentage value in parentheses after the Transferred value would solve this...

[poy (poy)]

now there's a new "% transferred" column (choosed a new column instead of adding the percentage in the "transferred" column so that the user can sort by percentage).

would it be ok to add a check-box in the "finished downloads grouped by files" status bar called "Only show items with % transferred >= 100%"? and make it default to checked, because it's a setting for newbies for whom having finished chunks in the "finished downloads" list makes no sense?

[eMTee (realprogger)]

I think its a good idea as it would be useful for those who use finished downloads only for opening really finished downloads.
Also here's a patch which corrects the displayed size and percentage of the finished filelists in finished downloads grouped by files ;)

[Jacek Sieka (arnetheduck)]

patch committed, in general it's safer not to call other managers inside Lock blocks (to avoid deadlocks)
check box sounds reasonable, just make sure it's saved when the window is closed...

[poy (poy)]

that size variable is only being used if the item is newly added, i.e. if it is the 1st downloaded segment. i put the File::getSize and alike functions inside the Lock block so that they are called only when the 1st segment finishes; now, they will get called everytime a segment finishes, but most of the time won't be used, which is a waste.
any idea on how the getSize functions could be called only when necessary, while still avoiding deadlocks?

[Jacek Sieka (arnetheduck)]

no simple ones...

[poy (poy)]

i put the File::getSize call for uploads back in the critical section part, since that's the one which shouldn't be called too often unnecessarily. the change shouldn't affect downloads, so deadlocks should be avoided correctly.