virtual directory sizes are not displayed correctly

Bug #226441 reported by endator
12
Affects Status Importance Assigned to Milestone
DC++
Confirmed
Low
Unassigned

Bug Description

version 0.706
 on the shared directory tab in settings, all directories for a virtual name are showing the total size of the virtual folder, not the individual folder size

Tags: core
Changed in dcplusplus:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Fredrik Ullner (ullner) wrote :

Fix for the bug.

I don't know if the function getShareSize() should instead be fixed (instead of introducing another function), but there may other components that rely on the current behaviour.

Revision history for this message
Fredrik Ullner (ullner) wrote :

Looks like I generated the diff file too quickly, had a missing paranthesis.

Fredrik Ullner (ullner)
Changed in dcplusplus:
status: Confirmed → In Progress
Revision history for this message
poy (poy) wrote :

getShareSize can indeed be fixed instead of the new addition; that size column in settings is its only use.

i am wary of iterating through every file... before pushing this in, i would like to know how well it fares for users with several thousand files. if opening settings freezes for more than say, 2 s, a better solution must be found (i can't think of any better way, unfortunately).

Revision history for this message
eMTee (realprogger) wrote :

With cca. 30k files shared for me it takes 8 seconds to open the settings.

Fredrik Ullner (ullner)
Changed in dcplusplus:
status: In Progress → Confirmed
Fredrik Ullner (ullner)
tags: added: core
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.