Deleting files from Incomplete DL folder corrups DL's

[Sparky55]

If incomplete files are deleted from the Incomplete DL folder, when DC++ 0.705 resumes downloading of that file, a file gets generated that seems to be the size of the deleted file. I am having a large number of larger .AVI files failing to work. This Bug would enplane this problem.

I noticed this when I cleared out the Incomplete DL folder, and started up DC++ V0.705, and a few downloads started from a resumed state, and within a few seconds a 22 MB file appeared. Another resumed a minute later and a 220 MB file appeared! Checking back a short while later another 390 MB file was there. Within 10 minutes, 1.33 GB was in the download folder, after the folder was empty, which is impossible for my cable connection to be able to download.

Previous versions of DC++ (0.6xx and earlier) would just start the file over from the beginning, which is expected. The incomplete folder needs the files cleared out sometimes, since incomplete downloads will eventually consume my entire hard drive partition!

OS: Win 2KPRo running DC++ 0.705

[Sparky55 (levy-jeff)]

Also note that I an NOT using the antifrag option, although the files have .antifrag at the end.

[Sparky55 (levy-jeff)]

Opening the 22 MB file, which is now a 28 MB file, up in a Hex editor, the first 22 MB of the file contains just 0x00!!! The remainder of the file contains actual data (~6 MB).

[Sparky55 (levy-jeff)]

Attached is a corrupted file

[eMTee (realprogger)]

Try it with 0.706 as probably it is fixed in the latest release (antifragmentation method is mandatory in 0.706 and cannot be disabled from now).

[Jacek Sieka (arnetheduck)]

actually, no, there's no check done if the temp file exists when resuming, so it's plausible that it's filled with 0's...the difference will be that in 0.706 the whole file will be recreated...

[Jacek Sieka (arnetheduck)]

committed fix needs testing...

[eMTee (realprogger)]

tested, bzr1276 fixed this...