The status of each hub

Bug #210117 reported by Pietry
4
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Wishlist
Unassigned

Bug Description

Quoting:
"
Granted it was high time the user interface were refreshed in dc++. Even if that means that us learning our way around what was arguably one of the least intuitive interfaces ever designed will go to waist. But it should have been refreshed and be made more functional, not less (an almost impossible feat by itself...). Since the designers unfortunately had to discover tabs in 2008 and implement them, can they explain to us how on earth we can know the status of our hubs? Back in the previous version, a hubs "tab" would turn green or red accordingly. What about in this, "improved" version? How are we to know ? Are we to open each one separately to check its status?
"

Revision history for this message
Pietry (pietry) wrote :

Moving to wishlist.

Changed in dcplusplus:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
poy (poy) wrote :

adds red icons for disconnected hubs and PMs. i also simplified a bit the way icons are added when the tab is created.

Revision history for this message
Jacek Sieka (arnetheduck) wrote :

Hm, getting the icon from the class is not a very good idea since the icon might have changed (in fact, I've considered registering just a single window class for all dwt windows since there's a limit on the number of open handles in general and classes too,...
(see http://msdn2.microsoft.com/en-us/library/ms632643(VS.85).aspx)

Revision history for this message
poy (poy) wrote :

ok, here is the same patch but without the get-icon-from-WindowClass stuff. maybe the icon for each child window shouldn't be added to that widow class since it's never used?

Revision history for this message
Jacek Sieka (arnetheduck) wrote :

either that or use the window class icon as initial tab icon and remove the icon from the add function which would be a step towards making it addchild-compatible...

Changed in dcplusplus:
status: Confirmed → Fix Committed
Revision history for this message
poy (poy) wrote :

"use the window class icon as initial tab icon and remove the icon from the add function" > hmm, this is exactly what the first patch was doing...

Revision history for this message
Jacek Sieka (arnetheduck) wrote :

right. hm - ok so we have two goals - make it addChild compatible and get rid of per-composite windowclasses... I think per-frame window classes still make sense though (frames being top-level windows)...bah. ignore that last comment then - this needs some more consideration =)

MikeJJ (mrmikejj)
Changed in dcplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.