Crash at download start with Spanish locale

[eMTee]

If locale set to se (Spanish) both 0.705 and svn1085 are crash when a download begins. Happens in ADC and NMDC hubs either. XP SP2, seems independent on OS language/regional settings.
To reproduce : set Spanish locale, go to a hub, try to get a filelist.
Related support issue : https://answers.launchpad.net/dcplusplus/+question/28363

[poy (poy)]

the crash happens because of the string which is on line 702 of TransferView.cpp:
ui->setStatusString(str(TF_("Requesting %1%") % getFile(d)));

the console window only tells the following when the crash happens:
terminate called after throwing an instance of 'boost::io::bad_format_string'
  what(): boost::bad_format_string: format-string is ill-formed

and GDB has no call stack to show.

the string seems translated correctly in the .po in the repository:
#: win32/TransferView.cpp:703
#, boost-format
msgid "Requesting %1%"
msgstr "Solicitando %1%"

however, in the .mo file provided with DC++ 0.705, this string has become:
Solicitando % 1%

besides fixing the translated string, there should be a way to catch that boost::bad_format_string exception and not make the whole program crash when an altered string is encountered...

[Kryppy (kryppy-one)]

I am sorry for this :(

i should be more attent when translating strings.my mistake

[Jacek Sieka (arnetheduck)]

tentatively fixed - could someone try this with the .mo file from 0.705?

[poy (poy)]

still crashes, same error message.

[poy (poy)]

attached patch works, the trick is to create an instance of basic_format with an empty string, so that it doesn't get parsed when it's created; then set the execptions to "no" (it's set to "all" in the basic_format constructor) and finally parse the string.

[Jacek Sieka (arnetheduck)]

looks good to me...