Disconnection during download init can cause a crash

Bug #188585 reported by Big Muscle
254
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Undecided
Unassigned

Bug Description

a) When download is being initialized (in DownloadManager::checkDownloads) and connection is disconnected at this time, DC++ can crash.
Patch is here: http://www.home.karneval.cz/01027053/tmp/DownloadManager.patch

b) When MerkleCheckOutputStream is created and no datas come yet, DC++ will crash if connection if disconnected.
Patch is here: http://www.home.karneval.cz/01027053/tmp/MerkleCheckOutputStream.patch

Both of these bugs could be exploited to crash DC++ remotely.

Revision history for this message
Jacek Sieka (arnetheduck) wrote :

applied a
b is better fixed at the source (merkletree.h)

one bug per patch please...

Changed in dcplusplus:
status: New → Fix Committed
MikeJJ (mrmikejj)
Changed in dcplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.