Crash on search

[Gul Paprika]

I've started getting crashes more or less everytime I search. It might be related to being connected to a lot of hubs but I'm not sure. Does not crash if I just connect to one hub and search.

I have Windows 10 64bit, Intel Core i7, 32GB ram.

Repro is just to search for anything common and being connected to a lot of hubs. It will even crash when it does automatic search for files already in queue, so search settings seems to be unrelated.

DC++ has crashed on 2017-01-05 at 17:13:20.
Please report this data to the DC++ team for further investigation.

DC++ version: DC++ v0.863 ("9794796d4ced - 2016-11-12 00:21 +0100")
TTH: XVSBEIW7E3DOPJFQ3AOB2N55DZRF33D2PN6VQ5Y
Compiled with MinGW-w64's GCC 6.2.0 (x64)
Exception code: c0000005
Windows version: major = 6, minor = 2, build = 9200, SP = 0, type = 1
Processors: 8 * x64
System memory installed: 31,93 GiB
Writing the stack trace...

DCPlusPlus: H:/mingw64/lib/gcc/x86_64-w64-mingw32/6.2.0/include/c++/bits/basic_string.h (142), function: Style getStyle(Identity const* const this, FastLock l)
DCPlusPlus: H:\Dev\DC++\repo/dcpp/Style.h (28), function: void/unknown onData(SearchManager* const this, string const& const x, string const& const remoteIp)
DCPlusPlus: H:\Dev\DC++\repo/dcpp/SearchManager.cpp (138), function: int run(SearchManager* const this, scoped_array<unsigned char> buf, int len, string remoteAddr)
DCPlusPlus: H:\Dev\DC++\repo/dcpp/Thread.h (110), function: DWORD starter(void/unknown p, Thread* t)
KERNEL32: [Failed to load the debugging data into memory (error: 2)] BaseThreadInitThunk
ntdll: [Failed to load the debugging data into memory (error: 2)] RtlUserThreadStart

Information about the crash has been written.

[eMTee (realprogger)]

Can you please try the same with version 0.862 as the latest release has changes in this area which might the cause of this problem.
You can get it from here : https://sourceforge.net/projects/dcplusplus/files/DC%2B%2B%200.862/

[Gul Paprika (gulpaprika)]

I could not repro this with 0.862

[eMTee (realprogger)]

Can you try it again with the attached test build (overwrite your installed DC++ binaries with it), which supposedly fixes the issue?
Thank you for your time!

[Gul Paprika (gulpaprika)]

I can not repro the crash on the new build, have tried for a good 5 min. Seems to be fixed!

[eMTee (realprogger)]

Good. You can safely use this build until a new version of DC++ is released.

[eMTee (realprogger)]

Patch attached.
Question is what to do with the result if the user is not online anymore. Do we need it or drop it in this case?
I think it's still useful if the result came because of an autosearch query, however, isn't there then a better/more useful value to add for the style object than the default it initialized with?

[poy (poy)]

your patch looks good to me:
- we did not ignore these results before; no reason to start ignoring them now.
- a default-initialized dcpp::Style is fine.

[poy (poy)]

Fixed in DC++ 0.864.