Automatic Connectivitiy Setup does not set Passive mode after all mapping attempts are unsuccessful (DC++ 0.86x)

[eMTee]

There were a couple of reports with connectivity problems after upgrading 0.851 -> 0.86x like https://answers.launchpad.net/dcplusplus/+question/402406 but it seems both reporters forgot to mention initally that they haven't had active mode at all, not even before the update. This has pointed the focus to possible mapping problems with the new MiniUPnP library, however, it does not seem to be the case.
As the title says their most probable problem is that instead of setting Passive mode, the auto conn setup leaves their connectivity in an indefinite state after all the port mapping attempts failed.

[eMTee (realprogger)]

See commit [f48813] for a fix. I tested it with a simulating the problem by breaking my connectivity but one of the reporters will get back to me later today with the result if it fixes the actual problem.

[poy (poy)]

the fix looks good; must have been lost during refactoring...

[poy (poy)]

just tried by simulating an error during port mapping; it does correctly select passive mode with the fix:

[18:29] Connectivity (IPv4): Determining the best connectivity settings...
[18:29] Connectivity (IPv4): Local network with possible NAT detected, trying to map the ports...
[18:29] Connectivity (IPv6): Determining the best connectivity settings...
[18:30] Connectivity (IPv4): Port mapping: Failed to initialize the MiniUPnP interface
[18:30] Connectivity (IPv4): Port mapping: Failed to map the Transfer port (53283 TCP) with the NAT-PMP interface
[18:30] Connectivity (IPv4): Port mapping: Failed to create port mappings
[18:30] Connectivity (IPv4): Active mode could not be achieved; a manual configuration is recommended for better connectivity

[poy (poy)]

Fixed in DC++ 0.862.