External / WAN IP address seems not to be saved

[Jo]

OS: Win10 DC++: 0.860 language: german
When you specify your external IP (or DNS name) under settings->connection->manual configuration and apply the settings, next time you open the settings the field is empty again. I am not sure if the IP or DNS name is not saved properly or it is simply not displayed in the field. It seems that after a program restart the information about the external IP is lost as searching and downloading is not working then.

[eMTee (realprogger)]

Yeah external IP changes don't seem to be written nor the actual values read properly from settings and it affects the nearby fields (e.g. the Allow override checkbox), too. I'm sure this worked well up to very recently, I suspect commit [7ad458] to cause this trouble but it might be something earlier.

[eMTee (realprogger)]

While trying to pinpoint the issue I found that the PropPage::Items map members in the PageContent classes are filled with the Ext IP & Allow override setting values but after that there's no PropPage::read() call to actually put the values into the GUI controls.
Similarly the GUI controls' values for these two settings per protocol are not being written to SettingsManager at closal of the dialog because of a missing PropPage::write() call for these items inside the PageContentV4/V6 classes.
Adding the PropPage::read / PropPage::write(items) calls to the PageContent::read / write () functions respectively makes the compiler complaining about the items map isn't even instantiated.
So something's missing here and I'm not sure how to fix this.

[poy (poy)]

thanks for the report Jo - fixed for the next version, to be released very soon.

commit 088f109aab8b

[poy (poy)]

Fixed in DC++ 0.861.