NSIS 3

[poy]

<http://nsis.sourceforge.net/Docs/AppendixF.html#v3.0> & <http://forums.winamp.com/showthread.php?s=6b0a69d25a659fe671294fb9cd03b587&t=395732>: NSIS 3 has been released, with Unicode support <http://nsis.sourceforge.net/Docs/Chapter4.html#aunicodetarget> -> Migrate to NSIS 3 from Unicode NSIS <http://www.scratchpaper.com/>, which hasn't been updated in a while.

[eMTee (realprogger)]

The current installer script builds and runs fine with NSIS 3.0 so I guess it's best to support both for the time being.

[maksis (maksis)]

I'd be more strict with the allowed NSIS version: https://textslashplain.com/2015/12/18/dll-hijacking-just-wont-die/

[poy (poy)]

ouch! yeah, better be up-to-date then...

eMTee, I notice you don't set the "unicode" flag <http://nsis.sourceforge.net/Docs/Chapter4.html#aunicodetarget> to "true" in the commit?

[eMTee (realprogger)]

poy, nope. Should have I? Compared to the old NSIS Unicode engine I don't see any difference in the way of look and work of the build with NSIS 3.0, using the committed script...

[eMTee (realprogger)]

I added "Unicode true" which now processes all nsh files and makes a multi language installer, though references of Hindi language must be removed from i18n.nsh to get an error free build.
Apparently the required files Hindi.nlf/nsh are missing from NSIS 3.0's Contrib\Language files\ folder.

[eMTee (realprogger)]

It's now NSIS 3.0 only and since the DC++ distro build script automatically checks for the available NSIS language files, missing languages in NSIS 3.0 should not be a problem when building the distro.

[poy (poy)]

that is annoying but not terribly important; adapted the script to be clearer about missing languages and created bug #1623625.

[poy (poy)]

Fixed in DC++ 0.860.