Support encoding in NMDC hubs

[Fredrik Ullner]

DC++ does not currently properly support the encoding in Favorites.xml.

[Fredrik Ullner (ullner)]

This adds proper support to the encoding for Favorites.xml (cologic's fix did NOT solve it). This is borrowed/copied from StrongDC++; I do not Believe BigMuscle would have a problem, as he has given full copyright assignment Before.

This patch also adds the ability for users to specify the encoding in the properties window in Favorite hubs.

[poy (poy)]

seems cool. can you make the UI part hidden when editing an ADC hub? or rather, the other way around - only show it when editing an NMDC hub?

[Fredrik Ullner (ullner)]

Added.

[eMTee (realprogger)]

The commit added "If you would like to use a special encoding. Leave this blank for default." to the help for this new function. How does one achieve such default setting using the GUI atm?
I see a normal dropdown list of encondings. It is not a list + edit combo which one could leave blank and there's no empty or 'Default' item in the list of encodings, either.
I already modified the help part to reflect the current state but indeed there would be nice to have some way to set an altered setting back to a Default value, just the way we do elsewhere in such dropdown list settings.

[poy (poy)]

by default it selects the current Windows encoding, which is what would happen without any setting. I see no issue with that logic.

[eMTee (realprogger)]

Well, it selects 37 (IBM EBCDIC - U.S./Canada) by default for me. I don't know what it is as I never heard about it (and I am pretty sure it's not the current encoding in my system - it should be either 852 or 1250) but I'm sure if a user selects something else for a try they will have hard time to find the default setting later.
We have the default value marked in such kind of lists elsewhere in the program (e.g. in the locale setting) and I miss the same feature here.

[poy (poy)]

Fixed in DC++ 0.860.