KEYP checks not in effect with default settings

Bug #1436105 reported by Crise / MW
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Fix Released
High
Crise / MW

Bug Description

I posted about this on the hub few days ago, figured it might be beneficial to do so here as well

The issue is that the "allow untrusted" options as they are now are honest to a fault, ie. they also disable all KEYP checks when turned on. The attached patch fixes this. The ConnectionManager and UserConnection changes are just a micro-optimization not to lookup the user twice if we already have it.

In theory we could also avoid verifying KEYP twice in such scenario (ie. just include the checkKeyprint() call to under the added if statement as well, because if it fails in the first place the execution never reaches this point, for outgoing connections).

Also, while this is more of a request it would be nice if someone would come up with a way to reflect the verify_callback error "KeyPrint mismatch" in HubFrame.

Revision history for this message
Crise / MW (markuwil) wrote :
Revision history for this message
Fredrik Ullner (ullner) wrote :

poy: Please verify this patch.

Changed in dcplusplus:
status: New → In Progress
importance: Undecided → High
Revision history for this message
poy (poy) wrote :

applied with minor changes (rev 0f3239d2f56c).

Changed in dcplusplus:
status: In Progress → Fix Committed
Revision history for this message
poy (poy) wrote :

Fixed in DC++ 0.860.

Changed in dcplusplus:
status: Fix Committed → Fix Released
eMTee (realprogger)
information type: Private Security → Public
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.