startup.lua in scripting plugin breaks handshake with ADC hubs

[RoLex]

Default startup.lua script included with ScriptPlugin breaks the handshake with any ADC(S) hub. Function adch.DataArrival checks for empty protocol message and returns nil in that case. For some reason this breaks the client to hub handshake. To fix this, function needs to return 1 instead.

This bug was reproduces with DC++ 0.843 and ApexDC++ 1.6.0, both x64 builds running on Windows 7.

My initial thread on ApexDC++ forum: http://forums.apexdc.net/topic/4678-still-cant-connect-to-adcs-hubs/

[poy (poy)]

thanks for investigating... why does the script get called with an empty message, though? maybe it's not the script that needs fixing but its callers?

[RoLex (hundrambit)]

Function adch.DataArrival is a handler function that is called directly by the plugin in Plugin::onHubDataIn, you should know better.

[poy (poy)]

-_- why so aggressive?

my question was directed at the plugin author(s), because you may have uncovered a bigger issue.

[RoLex (hundrambit)]

What is aggressive in my explanation? Lol. I'm just trying to report a bug.

Those who wrote that plugin should know better about this issue, I however, found a temporary solution and proposed it to others.

[poy (poy)]

ok, you didn't mean it that way but "should know better" is offensive in this context; it implies that it's foolish of authors not to have foreseen the issue. you wanted "would know more" / "would have more clue".

the patch is fine; i'll put it in soon unless another solution is found (on the caller side).

[poy (poy)]

hey,

i just tried the script plugin with default installs of DC++ & ADCH++ and i could connect fine (both locally and remotely to the DCDev hub).

[on Linux though.]

could anyone confirm? are there settings / other plugins that may be needed to reproduce?

[RoLex (hundrambit)]

Did you test it on Windows?