Transfer grouping issue crashes the client

Bug #1208049 reported by LoRenZo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Fix Released
High
Unassigned

Bug Description

I noticed with the recent releases (currently running r3332 x86) that the transfer group does not work properly.
I have attached a screenshot about the latest crash as there were no crash logs generated during either of the events.
The issue is based on that when a user is trying to downlad the same file trough multiple established connection, the grouping (when closed) shows less established connections as opposed to when its opened.
The drawing of the grouped downloads as displayed on the screenshot indicates that there are different files grouped under the same users.
The crash happens after opening the grouped list a few times.
The screenshot could not include at this point, but there were supposed to be 2 of the same files (first 2 only, excluding the TTH transfers and the files below) grouped.
I kept opening and closing it and each time there were more uploads (of TTHs and the files from the bottom) added to the same group, although it still showed 2/2 when closed, and that was the point when the crash occured.

Revision history for this message
eMTee (realprogger) wrote :

This was, somewhat, expected since the transferview code was changed for the sake of optimization and for fixing bug #1206658 .
Can you please confirm that your issue does not happen with a revision older than 3330?

Changed in dcplusplus:
importance: Undecided → High
Revision history for this message
LoRenZo (lorenzo-mailbox-deactivatedaccount) wrote :

Yes, I can confirm. I run r3327 until a similar case appeared. I could not crash the client.
I switched to r3333 and managed to crash it within seconds. This time a crash log was generated however.
I am also attaching a new screenshot for a better visual representation, too.

eMTee (realprogger)
Changed in dcplusplus:
status: New → Confirmed
Revision history for this message
LoRenZo (lorenzo-mailbox-deactivatedaccount) wrote :

It seems I was not entirely accurate before because the issue actually predates itself.
The latest releases definitely contain a more unstable solution for the painting part, but apparently the older revisions are suffering from a similar problem.

I reverted back to r3327 because I was hoping to have a more stable client running.
Since there was no crash log this time either, please refer to my third screenshot.
Kindly note that there are yet again more uploads listed than counted (first upload group).
Although this release does not react as sensitive as in case of the newer ones (the crash does not seems to be triggerable on-demand), it still might result in it.
Also notice the second group which I can actually recall seeing before but could not figure the point of it: there is only 1 connection established for a file yet it is still being displayed as being grouped. Pre-3330 relases are definitely affected by this (just a heads up for the re-design part).

A small remark to the filelist uploads: I would prefer having them ungrouped (at least in case of different users/IP addresses) as they should not have any relation between them.

Revision history for this message
poy (poy) wrote :

try rev 3335 - not tested but it should fix this.

Changed in dcplusplus:
status: Confirmed → Fix Committed
Revision history for this message
poy (poy) wrote :

Fixed in DC++ 0.830.

Changed in dcplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.