"Require TLS ADC C-C connections" is broken

[maksis]

The encryption is only checked at UserConnectionListener::Connected but only connections initiated by the other users come there. That setting has no effect when it's your client that connects to the other user.

Another issue is that DC++ tries to remove the source in the same location even though there is no user associated to the connection at that point. Luckily it won't crash the client since QueueManager::removeSource doesn't have any calls to the member variables of the user object.

AirDC++ checks the encryption support when receiving a CTM/RCM command, but also before adding the user as source and before trying to connect to the user. The code in AirDC++ has been rewritten from those parts so I'm not able to provide a tested patch.

[cologic (cologic)]

Relevant commits are http://sourceforge.net/p/dcplusplus/code/ci/f6328c715590639095ddd206b6d4bf82ba88353f/ and http://sourceforge.net/p/dcplusplus/code/ci/be5ef7f18629f9e5218259772cbcc46ea4897ff5/

[poy (poy)]

Fixed in DC++ 0.851.