Failure in the seach window

[dotniet]

This is a critical failure since the Search function is the starting point for any download.

1. Do a search.
2. When some results are received select and delete some of them.
3. Other search results (not only the ones selected) will be deleted also.

DC++ v0.825

[eMTee (realprogger)]

Anybody able to reproduce this? It works as expected for me using both the 'Remove' menu item and the Delete key regardless of the type of results or the location (single or combined result, subresult, etc...) or when any possible mixture of these are selected. Win XP, r3319.

[dotniet (cubicdesign)]

I think you need to select a row then let few rows unselected then select another row. In other words let few unselected rows between two selected rows. Do you want me to upload a series of screenshots.

PS: I used DEL key to delete the selection.

[eMTee (realprogger)]

Still can't repoduce. Also, I already tried more of such cases (skip rows, etc...) right after your report.

What is your operating system?
Do you use any custom visual styles/themes? If so could you disable them and use any stock windows theme and reproduce?

[dotniet (cubicdesign)]

>Still can't repoduce.
Damn it.

Win 7, 32 bit
I use classic Win 7 themes (aero).
I am a programmer too. I tell you: this cannot be a visual bug. I think it is not managing correctly the lists that holds the results.

Have you tried to delete stuff in two steps? It looks like the bug appears when you press DEL the second time.
Anyway, the bug DO exists! I can send you a movie.

[dotniet (cubicdesign)]

PS: you may want to compare the code of this version with the previous one to see what changed.
Maybe you can spot the problem EVEN if you cannot reproduce it.
:)

[poy (poy)]

the search result list has been heavily modified in this version to support grouping so bugs are certainly expected.

please do send that movie, but avoid any information such as the search query you mentioned in comment #3 (which i have now hidden).

are you sure you're not just removing a parent item (one whose value in the "Hits" column is > 1), resulting in the subsequent deletion of its children as well?

[dotniet (cubicdesign)]

> are you sure you're not just removing a parent item
yes, I am sure
I never open the parent (click the '+' sign) row

[iceman50 (bdcdevel)]

Reproduced with DC++ 0.825 Rev: 3319, Win 7 x64 MSVC (built in release, 64 bit)

[iceman50 (bdcdevel)]

how I reproduced is i did exactly as dotniet had pointed out with an exception out of the last 2 items remaining, the top result needs to have children, what happens is when deleted and the first item in the list has children and the last does not, is the result with children treats the bottom result as a child and therefore when the parent is deleted, both results get removed

[eMTee (realprogger)]

I can reproduce, too, the way iceman did; it also happens when the first item in the list has children and there are more than one items in the bottom without a child. But it always needed two delete operations for me to get the problem.

[dotniet (cubicdesign)]

Finally :)

Why is its importance set to low?
I do a lot of filtering (I delete unwanted results) in the search window. Since good/wanted results are deleted also, for me this is BASIC functionality failure. Especially ESPECIALLY for a user that doesn't know about this bug!!!

[iceman50 (bdcdevel)]

You are more than welcome to grab the source and find the bug yourself and submit a patch if you would like :) feel free to look at how we accept patches <http://dcplusplus.sourceforge.net/webhelp/dev_createpatch.html>

[poy (poy)]

should be fixed in rev 3321 (not tested).

[dotniet (cubicdesign)]

Great!

[poy (poy)]

Fixed in DC++ 0.828.