Crash after a couple of minutes. 0.822

Bug #1191099 reported by Leon van Heerden
256
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Critical
Unassigned

Bug Description

Running Windows 7 64Bit.

I have upgraded to 0.822. Tried 64bit and 32bit version and both crash after a couple of minutes of running.
I ran both through GDB (32bit and 64bit) and attached the traces in the attached zip file. None of the previous version has crashed like this?
There are 2 crashes for each version.

There is no nightly builds to test with.

Tags: crash
Revision history for this message
Leon van Heerden (leonvanheerden) wrote :
Revision history for this message
eMTee (realprogger) wrote :

Yes, this crash happens in a part of code that's been heavily modified since the previous release.
Can you tell us what column your Transfers list is sorted by? Did you changed the default sorting or coloum order or do you have the Transfers list enabled (visible) at all?

Changed in dcplusplus:
importance: Undecided → High
Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

Transfer list is sorted by Status .(the progress bar one)
I have included a picture of the app.

Is there anything else I can send that will help?

Revision history for this message
eMTee (realprogger) wrote :

Can you try with the following debug build http://rghost.net/private/46768126/145d4c2c97b685e6b02b4b65c7ad6c64
It'll produce a lot more output, hopefully also some useful ones right before the crash. Thank you.

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

Hi,
I ran it , but I see the debug symbols are not detected.
I tried to rename the files to remote the "_debug" in case it was looking for the original filename.

I attached the logs. Do you need me to run it again?

Revision history for this message
eMTee (realprogger) wrote :

Can you try the following command:

gdb --symbols=DCPlusPlus.pdb --exec=DCPlusPlus.exe

(substitute the filenames with the ones you renamed the debug build to)

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

*face palm* sorry, missed that .
I ran it with the parameters now. Here are the logs.

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

Ran it again with the 64bit debugger and busy running it again with the 32bit again now. Will upload the log again.
I don't know if it is significant, but no crashlog is being generated.

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

Here is another 32bit gdb log.
Let me know if there is anything else you would like me to try.

Revision history for this message
eMTee (realprogger) wrote :

Thank you very much. Your logs seem to be pretty much similar in terms of where the crash happens. We'll analyze the logs and get back to you if there's anything more you can test.

Btw., what version you're upgraded from? The automatic crashlogger built in DC++ (https://answers.launchpad.net/dcplusplus/+faq/337 , Method 1.) doesn't produce log at all?

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

Previous version was 0.811. Never really had any need for the crash report. the last crash report that was there was from 0.811

This is probably not relevant.
-------------
DC++ has crashed on 2013-05-22 at 16:57:24.
Please report this data to the DC++ team for further investigation.

DC++ version: DC++ v0.811 (r3214)
TTH: YBDKDKIKP3BPLRJVZGZR7ASQ3DKONOWRRQMTRXA
Compiled with GCC 4.7.2
Exception code: c0000005
Windows version: major = 6, minor = 1, build = 7601, SP = 1, type = 1
Processors: 4 * x64

Writing the stack trace...

DCPlusPlus: H:\Dev\DC++\repo/h:/mingw/bin/../lib/gcc/i686-w64-mingw32/4.7.2/../../../../include/c++/4.7.2/bits/basic_string.h (713)

Information about the crash has been written.

Revision history for this message
poy (poy) wrote :

1) does it still crash if you pause downloads then restart DC++ (so only uploads are running)?

2) anything special that you can notice before the crash? (missing text, wrong info...)

3) are you using a custom Win theme or a program that might be interfering with standard drawing in DC++?

4) can you try the dwt TreeTest program and see if anything strange happens in it, especially after clicking on column headers to apply different sorting rules? ("someone" please build it for Leon.)

Revision history for this message
poy (poy) wrote :

actually i already had the test mentioned in #4, here it is.

Revision history for this message
eMTee (realprogger) wrote :
Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

1. Will Test just upload.

2. Nope, will check when it crashes next time if there is missing text. If so, I will ad screen shot witht eh log.

3. Using Windows Standard Aero Theme. No third party themes.

4. I can run the testtree app. I shows 4 trees and I can open all 4 of them. When I click on an Item the corresponding Subitem is selected. I can't click on the Subitems. No problem running the tree app.

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

I attached a screenshot with 2 red arrows showing fields that were blank. The gdb log for that run is included.

Downloads was disabled for that run.

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

I could not run either the 32bit or the 64bit version of the test app from the tabletreetest that Poy linked too.
Both crash as soon as i run them.

Revision history for this message
eMTee (realprogger) wrote :

The 32-bit one poy linked in comment #13 crashes for me at start as well.
Leon, can you try this one (32-bit only)? : http://rghost.net/46774731
(I just built this with MinGW and works for me.)

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

eMtee, this one also crashes immediately for me. Is shows the main form, both crashes before anything shows.
Ran it through gdb, it states no stack when trying to do the bt full:

Starting program: C:\Program Files (x86)\DC++\TableTreeTest.exe
[New Thread 8172.0xd20]
[New Thread 8172.0x1e44]
warning: Invalid parameter passed to C runtime function.

warning: Invalid parameter passed to C runtime function.

[Inferior 1 (process 8172) exited with code 03]
(gdb) bt full
No stack.
(gdb)

Revision history for this message
poy (poy) wrote :

oops, that test was relying on an icon i forgot to distribute. here it is again with a default Win icon.

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

Both version open without errors.
Was there something specific I was supposed to see/test?

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

Something extra.
I ran the Debug version you supplied above, without gdb, and I see there is a command prompt window that shows debug information while it is running.
I waited for it to crash again and i could see in the debug window that the system is still running and uploading/downloading. The front end just crashed.
I also see that there is always 2 blank entries when it crashes. I have included a screenshot of the entries so you can see what I mean.

Revision history for this message
eMTee (realprogger) wrote :

Those should be partial lists or full Tiger tree requests which is normal ( those transfers are not associated with a particular file or path so nothing's shown there).
However, the icons displayed look a bit strange, at least the one displayed for the empty items (I guess that's something registered for the empty file extension in your Windows). Can you try to disable "Settings / Advanced / Use system icons when browsing files" checkbox and see if it still crashes?

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

Hi, eMTee,
I have tried disabling the Icons and so far it has been running for 15 minutes and didn't crash.

And of course as I type this message it crashed again.
There were 2 blank entries again. Not the same users as before.

Revision history for this message
poy (poy) wrote :

that was some fine investigative work...

rev 3312 should fix this. releasing tomorrow if no other problem shows up.

Changed in dcplusplus:
status: New → Fix Committed
Revision history for this message
eMTee (realprogger) wrote :

You can get the rev 3312 build here: http://rghost.net/46830883 This should fix the issue, regardless of the state of "Settings / Advanced / Use system icons when browsing files".
Please report back if you find anything unusual. Thank you for your time!

Revision history for this message
Leon van Heerden (leonvanheerden) wrote :

Thank you very much. I downloaded this version last night and let it run through the night. No issues. It is still running now.
No more crashes so far.

Revision history for this message
poy (poy) wrote :

Fixed in DC++ 0.825.

Changed in dcplusplus:
status: Fix Committed → Fix Released
eMTee (realprogger)
information type: Public → Public Security
Changed in dcplusplus:
importance: High → Critical
To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.