Extra whitespace in command $Supports

Bug #1102181 reported by Tehnick
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Won't Fix
Undecided
Unassigned

Bug Description

Hi,

Command $Supports now has extra whitespace in DC++ and derivatives. For example:
$Supports UserCommand NoGetINFO NoHello UserIP2 TTHSearch ZPipe0 GetZBlock |

Please fix files [1][2] in according to standard [3]. Fix is trivial [4], we already did it in EiskaltDC++.

[1] https://bazaar.launchpad.net/~dcplusplus-team/dcplusplus/trunk/view/head:/dcpp/NmdcHub.cpp#L108
[2] https://bazaar.launchpad.net/~dcplusplus-team/dcplusplus/trunk/view/head:/dcpp/UserConnection.cpp#L179
[3] http://web.archive.org/web/20040703015607/http://dcplusplus.sourceforge.net/wiki/index.php/Supports%20command
[4] https://github.com/eiskaltdcpp/eiskaltdcpp/commit/9cb1004

Thanks!

Revision history for this message
iceman50 (bdcdevel) wrote :

I'm not sure I see the importance of this as A) it's only a space ... not a big deal, B) NMDC protocol is frozen in DC++ so any changes regarding the protocol in *any* way would be considered a change and therefore disallowed as there is no *official* specification.

Revision history for this message
poy (poy) wrote :

this extra space has been in for years (i just checked DC++ 0.307) so it is not unreasonable to assume programs out there may be relying on its presence; it is therefore going to remain.

Changed in dcplusplus:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.