Memory leaking during some user activity

[LoRenZo]

I have recently discovered that every time the Settings dialog is opened, the client's memory usage is increased with the same amount. After closing the dialog, the only a small part of the previously allocated memory is recovered.

For reproducing what I have experienced, please execute the following steps while having the Task Manager opened:

1. Start the client without connecting to any hub
2. Notice the current memory usage of the client
3. Open the Settings dialog and see the memory usage being increased somewhat
4. Close the dialog and notice the only a small part of the recently allocated memory is being released
5. Repeat steps #3 and #4 and see how the same keeps happening over and over again.

I have tested this with both the latest published revision of the x68 and x64 branch.
The only difference was that in case of the x64 build the memory consumption was a bit higher (~250KB in case x86 and ~350KB in case of the x64 build), but each time I triggered this, the used amount appeared to be the same for the individuals.

I have encountered similar behaviour in case of the following events as well:

- opening and closing the ADL Search window
- opening and closing Search window(s)
- opening and closing the Open file dialog
- opening and closing the About dialog

As a sidenote: in contrary to this, opening and closing the Finished Uploads and Finished Downloads resulted in releasing the allocated memory, though they were both empty during the tests, however, this is the behaviour that I would rather expect in case of the above listed issues too.
Also, some other events (opening empty Favorite Hubs, Favorite Users, Notepad, Network Statistics - with no current traffic -, System Log and refreshing the - empty - Filelist) did not consume additional memory.

Please be aware of that I have kept the clients running for hours (without doing anything else) after testing this thoroughly, and the allocated memory was never actually freed up until the client was running.

I would also like to add that these issues might be related to https://bugs.launchpad.net/dcplusplus/+bug/1029629 directly (and perhaps to some others too), and I am basing this merely on the fact that at I least once encountered crashing my long term running client right after I had clicked on the Settings icon.
The Settings dialog is being used by me quite a lot, 10 times a day at minimum, and I am also using the search feature from time to time. You can guess that in a couple of days using them constantly or occasionally adds on increasing the chance of an undesired crash.

In addition, I think there might be a relevance for some of these events, as the DCPlusPlus.xml and ADLSearch.xml are being saved every time you close the Settings dialog and the ADL Search frame. You might want to check that part of the code as well.

If I may, I would suggest you to leave my other reports behind until you conclude whether these are real problems, and in case they are, please try to fix these in the first place, which will perhaps result in marking the other reports as obsolete ones.

If you have any question or conecrn regarding this report, please feel free to share them with me.

[eMTee (realprogger)]

I can confirm most of what's reported here.
Repeatedly opening / closing the settings window enough times firmly causes a crash as well as opening large number of Search windows.
Tested with r3258