DB Version

ClassicVersion does not order versions correctly

Bug #862222 reported by Colin Winning
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DB Version
Fix Committed
High
Colin Winning
DB Version 0.2

Bug Description

The ClassicVersionComparer does not use the correct property when comparing two versions. It currently uses the Version property (which is a string) when it should really use the SystemVersion property.

The example is 4.9 and 4.10. Using the string "Version" property 4.10 comes before 4.9. Using the SystemVersion property 4.10 would correctly come after 4.9.

Related branches

lp:dbversion
Colin Winning (colinwinning)
Changed in dbversion:
assignee: nobody → Colin Winning (colinwinning)
importance: Undecided → High
Revision history for this message
Adam Connelly (adam-rpconnelly) wrote :

Hey Colin, can I get you to add a test for this? Just use the example from the bug description.

Revision history for this message
Colin Winning (colinwinning) wrote :

Still need to add tests for this

Changed in dbversion:
status: New → In Progress
Adam Connelly (adam-rpconnelly)
Changed in dbversion:
milestone: none → 0.2
Revision history for this message
Adam Connelly (adam-rpconnelly) wrote :

I've added a test for the bug and am just marking this as fixed.

Changed in dbversion:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.