Exit Code not being set correctly
Bug #1039969 reported by
Colin Winning
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
DB Version |
Fix Committed
|
High
|
Colin Winning |
Bug Description
The program now swallows Task Execution Exceptions. This means that even when an exception is thrown, the program gives the impression of exiting normally.
This is not helpful when being run as part of a build as the build continues normally even although a problem has occured when running dbversion.
The correct thing would be to handle the exceptions but acknowledge that a problem has occurred and set the exit code correctly.
Related branches
lp:~colinwinning/dbversion/exitcode
- Adam Connelly: Approve
-
Diff: 384 lines (+94/-39)14 files modifiedsrc/DatabaseVersion.Console.Tests/Command/Create/CreateCommandTests.cs (+36/-0)
src/DatabaseVersion.Console/Command/CommandManager.cs (+8/-5)
src/DatabaseVersion.Console/Command/ConnectionCommandBase.cs (+5/-4)
src/DatabaseVersion.Console/Command/Create/CreateCommand.cs (+8/-6)
src/DatabaseVersion.Console/Command/Help/HelpCommand.cs (+5/-3)
src/DatabaseVersion.Console/Command/History/HistoryCommand.cs (+7/-5)
src/DatabaseVersion.Console/Command/ICommandManager.cs (+3/-2)
src/DatabaseVersion.Console/Command/IConsoleCommand.cs (+3/-2)
src/DatabaseVersion.Console/Command/SavedConnection/SavedConnectionCommand.cs (+3/-2)
src/DatabaseVersion.Console/Command/Version/DisplayVersionCommand.cs (+6/-3)
src/DatabaseVersion.Console/Program.cs (+2/-1)
src/DatabaseVersion/DatabaseCreator.cs (+5/-3)
src/DatabaseVersion/IDatabaseCreator.cs (+1/-1)
src/DatabaseVersion/Session/SessionFactoryProvider.cs (+2/-2)
Changed in dbversion: | |
assignee: | nobody → Colin Winning (colinwinning) |
importance: | Undecided → High |
Changed in dbversion: | |
status: | New → Fix Committed |
milestone: | none → 0.2 |
To post a comment you must log in.