Menu icons don't scale with font size

Bug #541472 reported by Ted Gould
40
This bug affects 15 people
Affects Status Importance Assigned to Milestone
DBus Menu
Confirmed
Low
Unassigned
The Sound Menu
Confirmed
Low
Unassigned
libindicator
Confirmed
Low
Unassigned
gnome-settings-daemon (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

The messaging menu and system menu currently use GTK_ICON_SIZE_MENU for the size of their icons. Unfortunately, GTK_ICON_SIZE_MENU does not change when the system font size changes, and is apparently hard-coded inside GTK.

There should be a signal when the font size changes, gnome-settings-daemon should update gtk-icon-sizes to reflect the new size, and menus should be redrawn automatically.

<http://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-icon-sizes>

Tags: design
Revision history for this message
Kenneth Wimer (kwwii) wrote :

All panel icons and panel menu icons should use 22px width icons.

Changed in dbusmenu:
status: New → Confirmed
Changed in indicator-messages:
status: New → Confirmed
Changed in libindicator:
status: New → Confirmed
Changed in indicator-sound:
status: New → Confirmed
Changed in dbusmenu:
importance: Undecided → High
Changed in indicator-messages:
importance: Undecided → High
Changed in indicator-sound:
importance: Undecided → High
Changed in libindicator:
importance: Undecided → High
Revision history for this message
Kenneth Wimer (kwwii) wrote :

LOL, all panel icons and panel menu icons should use 22px HEIGHT icons, width should be variable. Duh!

Ted Gould (ted)
Changed in dbusmenu:
importance: High → Low
Changed in indicator-messages:
importance: High → Low
Changed in indicator-sound:
importance: High → Low
Changed in libindicator:
importance: High → Low
Conor Curran (cjcurran)
tags: added: design
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I propose that for consistency, except in exceptional circumstances, every menu item that has an icon should be the same height as an item that doesn't have an icon.

The "Applications" and "Places" menus used to be exceptional circumstances, because almost every item in those menus was a launcher (the Windows Start menu made every item oversized for the same reason). But now that those menus are being retired, any inconsistency elsewhere -- such as in the messaging and sound menus -- would be even more obvious.

At the default font size, Nautilus's "Open With" submenu and "Places" menu have nice examples of icons that don't make their items any taller. Unfortunately, in Ubuntu 10.10 at least, the icons don't increase when the font size does.

So, I think the ideal approach would be to change whatever constant or function programs like Nautilus use, so that the icon is the same size as it is now in the default font size, but scales up as the font size increases. And then to use that same constant or function for the messaging and sound menus.

Conor Curran (cjcurran)
Changed in ayatana-design:
status: New → Confirmed
Revision history for this message
Lars Karlitski (larsu) wrote :

What's the status on this?

Matthew's proposal in comment #3 (all menu items with icons should have the same height as those without icons) is now true for all indicators as far as I can see.

The original description is about the icons having a specific size different from the one we use now. Is this still relevant?

Revision history for this message
Otus (jan-varho) wrote :

Not fixed, in Precise at least.

Try changing the system font size, looking at the Nautilus 'Go' menu or 'Open with' in the context menu. AFAICT the icons stay the same size regardless of font size. With font size smaller than the default, the menu items with icons are larger and with larger font the icons look tiny.

(You can see this using the small and large text size from accessibility, but it is clearer with system font sizes 5 and 20 from e.g. myunity.)

description: updated
no longer affects: indicator-messages
no longer affects: ayatana-design
description: updated
Revision history for this message
Conscious User (conscioususer) wrote :

I'm not 100% sure on this, but this might not be very easy to patch. If I remember correctly, icon sizes are read just once and never again. I think simply changing the constant would work for *new* icons, but wouldn't auto-resize the ones already rendered.

It's worth mentioning that the GNOME HIG itself hardcodes icon sizes:

http://developer.gnome.org/hig-book/3.5/icons-types.html.en

so I wouldn't be surprised if implementing auto-resizing is not very easy.

summary: - Menu icons should not be 16x16 px
+ Menu icons don't scale with font size
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-settings-daemon (Ubuntu):
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.