Moon phase lacks needed space in English
Bug #1543793 reported by
Kyle Nitzsche
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Day Scope |
Fix Released
|
Medium
|
Penk Chen |
Bug Description
In English, the moon phase lacks a space, for example "fullmoon" and "waninggibbous".
Related branches
lp:~knitzsche/day-scope/bugfix-1543793-english-moon-phase-names
- Jin: Pending requested
-
Diff: 434 lines (+208/-52)4 files modifiedCMakeLists.txt (+2/-2)
include/query.h (+12/-4)
src/CMakeLists.txt (+6/-6)
src/query.cpp (+188/-40)
Changed in day-scope: | |
status: | In Progress → Fix Committed |
tags: |
added: ota10 removed: 10 ota |
Changed in day-scope: | |
assignee: | Penk Chen (penk) → Elsa Wang (elsawang) |
Changed in day-scope: | |
assignee: | Elsa Wang (elsawang) → Ethan Chang (ethan.chang) |
To post a comment you must log in.
This is because the moon phase provided to the scope by the web api lacks the space. Our translators worked around this by adding a space to translations, but in English, which is not translated, there is no space.
A fix is to check at run time whether the current locale is for english and if so, don't try to translate it. Instead, provide the corrected terms.