There's no defend action emitted when defending in a fight

[Erik Ogenvik]

When fighting, an "attack" action is emitted when one entity attacks, but no "defend" action is emitted for the entity which defends. There's animations for it on the client, so it should be emitted as well to make the action more lively.

[Al Riddoch (alriddoch)]

Just for clarification, is the action an Action operation, or other operation you are receiving? IIRC combat issues Sight(Imaginary()) operations, giving emotes of the actions the characters are performing, and may also issue more semantic operations intended to trigger animations on the client.

Please give details of the operations you are getting, and those you expect.

[Erik Ogenvik (erik-ogenvik)]

There's Imaginary ops for both attack and defend, but there's only attack Actions being sent. The animation system in Ember only reacts to Actions, so the end result is that only the attack animation is played.

It might be that we need to extend the animation system in Ember to also listen to Imaginary ops? I'm not completely on the clear on when the server should send Actions and when to send Imaginary during tasks.

[Al Riddoch (alriddoch)]

No, don't use Imaginary ops to trigger animations. They are non semantic, and the text can change arbitrarily without warning. They can also be freely generated by the user.

[Erik Ogenvik (erik-ogenvik)]

That's what I though also. I remember us talking about this before too. :)