There should be one instance of tool per image

Bug #633232 reported by janisozaur
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Carto
High
Krzysztof Klimczak

Bug Description

Currently, there is only one, global, tool instance per one carto instance.
This is bad, as in a threaded solution implemented recently one thread has to paint on multiple images simultaneously and it is not only counterproductive, but also complex and cumbersome to implement. Due to this, after creating second image and trying to paint in it, carto crashes.
You can verify this issue by inspecting output from http://bazaar.launchpad.net/%7Ecarto-team/cybercarto/carto/annotate/head%3A/paintarea.cpp#L459.
There should be one instance of tool (thread) per image, they can share settings, though.

Changed in cybercarto:
assignee: nobody → Krzysztof Klimczak (klimczak-k)
Revision history for this message
janisozaur (janisozaur) wrote :

duplicated in bug 636377

Revision history for this message
janisozaur (janisozaur) wrote :

The commited fix is sort of a workaround - it stores the read/write thread client and host, respectively, indices in image. This lets us to avoid aforementioned problems at the expense of painting on only one image at any given time (i.e. there is no possibility of any deferred actions, as they might get lost).

janisozaur (janisozaur)
Changed in cybercarto:
status: New → In Progress
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers