multipath parent device may need unmapping to release hold on disks

[Ryan Harper]

In our vmtest scenario for multipath the removal wiping of the underlying path element would fail if the multipath mapping for the device was present; this causes an installation failure.

[Chad Smith (chad.smith)]

Do we have a log, traceback, subiquity bug or jenkins CI job that ran into this?

[Ryan Harper (raharper)]

[ 88.709877] cloud-init[809]: Traceback (most recent call last):
[ 88.710852] cloud-init[809]: File "/curtin/curtin/commands/main.py", line 202, in main
[ 88.714853] cloud-init[809]: ret = args.func(args)
[ 88.715720] cloud-init[809]: File "/curtin/curtin/log.py", line 97, in wrapper
[ 88.717063] cloud-init[809]: return log_time("TIMED %s: " % msg, func, *args, **kwargs)
[ 88.719463] cloud-init[809]: File "/curtin/curtin/log.py", line 79, in log_time
[ 88.722392] cloud-init[809]: return func(*args, **kwargs)
[ 88.723299] cloud-init[809]: File "/curtin/curtin/commands/block_meta.py", line 79, in block_meta
[ 88.725877] cloud-init[809]: meta_clear(devices, state.get('report_stack_prefix', ''))
[ 88.728655] cloud-init[809]: File "/curtin/curtin/commands/block_meta.py", line 1714, in meta_clear
[ 88.733926] cloud-init[809]: clear_holders.clear_holders(devices)
[ 88.734960] cloud-init[809]: File "/curtin/curtin/block/clear_holders.py", line 646, in clear_holders
[ 88.738874] cloud-init[809]: shutdown_function(dev_info['device'])
[ 88.739870] cloud-init[809]: File "/curtin/curtin/block/clear_holders.py", line 307, in wipe_superbloc
k
[ 88.741448] cloud-init[809]: _wipe_superblock(mp_dev if mp_dev else blockdev)
[ 88.744671] cloud-init[809]: File "/curtin/curtin/block/clear_holders.py", line 355, in _wipe_superblo
ck
[ 88.746179] cloud-init[809]: exclusive=exclusive, strict=strict)
[ 88.748710] cloud-init[809]: File "/curtin/curtin/block/__init__.py", line 1127, in wipe_volume
[ 88.751119] cloud-init[809]: quick_zero(path, partitions=False, exclusive=exclusive, strict=strict)
[ 88.754240] cloud-init[809]: File "/curtin/curtin/block/__init__.py", line 1041, in quick_zero
[ 88.755434] cloud-init[809]: exclusive=exclusive, strict=strict)
[ 88.757729] cloud-init[809]: File "/curtin/curtin/block/__init__.py", line 1061, in zero_file_at_offse
ts
[ 88.760699] cloud-init[809]: with exclusive_open(path, exclusive=exclusive) as fp:
[ 88.763491] cloud-init[809]: File "/usr/lib/python3.7/contextlib.py", line 112, in __enter__
[ 88.764845] cloud-init[809]: return next(self.gen)
[ 88.767372] cloud-init[809]: File "/curtin/curtin/block/__init__.py", line 954, in exclusive_open
[ 88.770156] cloud-init[809]: fd = os.open(path, flags)

[Ryan Harper (raharper)]

This commit fixes this issue:

https://git.launchpad.net/curtin/commit/?id=29cfab332c641658e0f548fc4702c3f4898996a4