live-server install with encrypted volumes run update-initramfs twice
Bug #1842264 reported by
Michael Hudson-Doyle
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| curtin |
Fix Committed
|
High
|
Ryan Harper | ||
Bug Description
I installed my shiny new NVMe laptop with the server installer last week. The curtin invocation took about 100 seconds which is pretty good, but it ended up running update-initramfs twice, at 15 seconds each -- once when the kernel was installed and once after crypttab had been copied to the target system. I guess this is pretty minor at the end of the day, but it would be nice to avoid it if we could somehow.
Related branches
~raharper/curtin:fix/initramfs-only-once
- Server Team CI bot: Approve (continuous-integration)
- Michael Hudson-Doyle: Approve
- Dan Watkins (community): Needs Information
- Paride Legovini: Needs Fixing
-
Diff: 537 lines (+296/-55)5 files modifiedcurtin/commands/block_meta.py (+16/-17)
curtin/commands/curthooks.py (+113/-14)
examples/tests/dirty_disks_config.yaml (+1/-1)
tests/unittests/test_curthooks.py (+162/-20)
tests/vmtests/__init__.py (+4/-3)
| tags: | added: originate-from-1839820 somerville |
| affects: | curtin → linux (Ubuntu) |
| affects: | linux (Ubuntu) → curtin |
| no longer affects: | hwe-next |
| tags: | removed: originate-from-1839820 somerville |
| Changed in curtin: | |
| status: | New → Triaged |
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | #1 |
| Changed in curtin: | |
| importance: | Undecided → High |
| assignee: | nobody → Ryan Harper (raharper) |
| Changed in curtin: | |
| status: | Triaged → In Progress |
Revision history for this message
| Server Team CI bot (server-team-bot) wrote | #2 |
| Changed in curtin: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
So fwiw what livecd-rootfs does is divert initramfs at the beginning to be a noop, and at the end undivert it and run it once.