md_check_array_membership should pass export=True to mdadm_examine

Bug #1830157 reported by Michael Hudson-Doyle on 2019-05-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
curtin
Undecided
Michael Hudson-Doyle

Bug Description

Testing a first cut of subiquity with existing partitions failed to install even if I didn't touch the existing RAID I had set up. I think the underlying reason is this code in md_check_array_membership:

        dev_examine = mdadm_examine(device, export=False)
        if 'MD_UUID' not in dev_examine:
            raise ValueError('Device is not part of an array: ' + device)

mdadm_examine(device, export=False) is never going to return a dictionary with MD_UUID in it. Is it just supposed to be export=True?

I can't find any tests of type=raid, preserve=true so we'll see how many of these I find...

Related branches

Paride Legovini (legovini) wrote :

Hi Michael, I can't really tell if that's the only cause of the problem, but it definitely looks as part of it.

Changed in curtin:
status: New → Triaged
Changed in curtin:
status: Triaged → In Progress
assignee: nobody → Michael Hudson-Doyle (mwhudson)

This bug is fixed with commit b6e8a1c1 to curtin on branch master.
To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=b6e8a1c1

Changed in curtin:
status: In Progress → Fix Committed

This bug is believed to be fixed in curtin in version 19.2. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Changed in curtin:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers