curtin

Please generate version 4 block device UUIDs, not version 1

Bug #1785356 reported by Tom Reynolds
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
curtin
Fix Released
Medium
Unassigned
subiquity
Fix Released
Undecided
Unassigned

Bug Description

Using the 18.04.1 server-live installer with manual partitioning, the installed system ends up with an fstab like this:

UUID=d94e7ea3-9785-11e8-b625-080027681a6b / ext4 defaults 0 0
UUID=d94e7ea2-9785-11e8-b625-080027681a6b /boot ext4 defaults 0 0
/swap.img none swap sw 0 0

The block device UUIDs generated here are very similar, which may abet user errors. The classic Ubuntu server installer generates version 4 UUIDs which provide much more variance.

This may be visualized by using, for example, the bulk UUID generators version 1 and 4 at https://www.uuidonline.net/

https://tools.ietf.org/html/rfc4122#section-4.1.3
https://en.wikipedia.org/wiki/Universally_unique_identifier#Versions

See original description

Related branches

~chad.smith/curtin:ubuntu/devel
Server Team CI bot: Approve (continuous-integration)
Scott Moser (community): Approve
Diff: 2225 lines (+662/-342)
51 files modified
bin/curtin (+1/-1)
curtin/__main__.py (+4/-0)
curtin/block/__init__.py (+14/-10)
curtin/block/clear_holders.py (+24/-2)
curtin/block/mkfs.py (+2/-2)
curtin/commands/__main__.py (+4/-0)
curtin/commands/curthooks.py (+3/-1)
curtin/commands/features.py (+20/-0)
curtin/commands/main.py (+3/-3)
debian/changelog (+25/-0)
doc/topics/integration-testing.rst (+4/-0)
doc/topics/storage.rst (+79/-3)
examples/tests/install_disable_unmount.yaml (+2/-2)
examples/tests/mirrorboot-msdos-partition.yaml (+2/-2)
examples/tests/mirrorboot-uefi.yaml (+4/-4)
examples/tests/vmtest_pollinate.yaml (+10/-0)
tests/unittests/test_clear_holders.py (+94/-38)
tests/vmtests/__init__.py (+201/-73)
tests/vmtests/releases.py (+19/-20)
tests/vmtests/test_apt_config_cmd.py (+2/-2)
tests/vmtests/test_basic.py (+20/-10)
tests/vmtests/test_bcache_basic.py (+2/-2)
tests/vmtests/test_bcache_bug1718699.py (+2/-2)
tests/vmtests/test_fs_battery.py (+4/-0)
tests/vmtests/test_iscsi.py (+2/-2)
tests/vmtests/test_journald_reporter.py (+2/-2)
tests/vmtests/test_lvm.py (+3/-2)
tests/vmtests/test_lvm_iscsi.py (+2/-2)
tests/vmtests/test_lvm_root.py (+5/-35)
tests/vmtests/test_mdadm_bcache.py (+17/-21)
tests/vmtests/test_mdadm_iscsi.py (+2/-2)
tests/vmtests/test_multipath.py (+2/-2)
tests/vmtests/test_network.py (+2/-2)
tests/vmtests/test_network_alias.py (+2/-2)
tests/vmtests/test_network_bonding.py (+15/-26)
tests/vmtests/test_network_bridging.py (+18/-26)
tests/vmtests/test_network_ipv6.py (+2/-2)
tests/vmtests/test_network_ipv6_static.py (+2/-2)
tests/vmtests/test_network_ipv6_vlan.py (+2/-2)
tests/vmtests/test_network_mtu.py (+4/-12)
tests/vmtests/test_network_static.py (+2/-2)
tests/vmtests/test_network_static_routes.py (+2/-2)
tests/vmtests/test_network_vlan.py (+3/-3)
tests/vmtests/test_nvme.py (+5/-4)
tests/vmtests/test_pollinate_useragent.py (+3/-0)
tests/vmtests/test_raid5_bcache.py (+2/-2)
tests/vmtests/test_simple.py (+2/-2)
tests/vmtests/test_uefi_basic.py (+4/-4)
tests/vmtests/test_zfsroot.py (+6/-2)
tools/xkvm (+5/-1)
tox.ini (+1/-1)
~raharper/curtin:fix/lp1785356-switch-to-uuid4
Scott Moser (community): Approve
Server Team CI bot: Approve (continuous-integration)
Diff: 41 lines (+7/-3)
2 files modified
curtin/block/mkfs.py (+2/-2)
tools/xkvm (+5/-1)
Tom Reynolds (tomreyn)
summary: - Please generate version 4 UUIDs, not version 1
+ Please generate version 4 block device UUIDs, not version 1
description: updated
Tom Reynolds (tomreyn)
description: updated
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This will need to be addressed in curtin.

Ryan Harper (raharper)
Changed in curtin:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Ryan Harper (raharper) wrote :

We'll switch curtin to UUID4 values as fallback when a UUID value is not provided.

Subiquity can generate UUID4 values, and pass that into the storage config, and those values will be used instead of curtin (currently) generating uuid1 values.

http://curtin.readthedocs.io/en/latest/topics/storage.html#format-command

Ryan Harper (raharper)
Changed in curtin:
status: Confirmed → In Progress
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

This bug is fixed with commit 1845c22a to curtin on branch master.
To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=1845c22a

Changed in curtin:
status: In Progress → Fix Committed
Revision history for this message
Ryan Harper (raharper) wrote : Fixed in curtin version 18.2.

This bug is believed to be fixed in curtin in version 18.2. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Changed in curtin:
status: Fix Committed → Fix Released
Michael Hudson-Doyle (mwhudson)
Changed in subiquity:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.