curtin output badly broken. command errors ignored.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
curtin |
Fix Released
|
Critical
|
Blake Rouse | ||
curtin (Ubuntu) |
Fix Released
|
Undecided
|
Blake Rouse |
Bug Description
This regressed with the 'reporter' code in revno 163.
The following shows a number of issues:
a.) cannot run as non-root (as it wants to write to /var/log/
b.) failure codes are ignored causing stage commands to run even after one fails
c.) output is duplicated
d.) *old* output from /var/log/
$ cat foo.cfg
stages: ['foo']
foo_commands:
builtin: ['sh', '-c', 'echo FOO_BUILTIN; exit 1;']
zz: ['sh', '-c', 'echo FOO_ZZ']
$ cat bar.cfg
stages: ['bar']
bar_commands:
builtin: ['sh', '-c', 'echo BAR_BUILTIN; exit 1;']
zz: ['sh', '-c', 'echo BAR_ZZ']
$ sudo rm /var/log/
$ ./bin/curtin -v install --config=foo.cfg my-source
'reporter' not found in config file.
Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib/
self.run()
File "/usr/lib/
self.
File "/home/
with io.open(
IOError: [Errno 13] Permission denied: '/var/log/
Exception in thread Thread-2:
Traceback (most recent call last):
File "/usr/lib/
self.run()
File "/usr/lib/
self.
File "/home/
with io.open(
IOError: [Errno 13] Permission denied: '/var/log/
[Errno 13] Permission denied: '/var/log/
$ sudo ./bin/curtin -v install --config=foo.cfg my-source
'reporter' not found in config file.
FOO_BUILTIN
FOO_BUILTIN
FOO_BUILTIN
FOO_BUILTIN
FOO_ZZ
FOO_ZZ
$ sudo ./bin/curtin -v install --config=bar.cfg my-source
'reporter' not found in config file.
FOO_BUILTIN
FOO_ZZ
FOO_BUILTIN
FOO_ZZ
Installation finished.
Installation finished.
BAR_BUILTIN
FOO_BUILTIN
FOO_ZZ
Installation finished.
FOO_BUILTIN
FOO_ZZ
Installation finished.
BAR_ZZ
BAR_ZZ
Changed in curtin: | |
assignee: | nobody → Blake Rouse (blake-rouse) |
status: | New → Triaged |
status: | Triaged → In Progress |
importance: | Undecided → Critical |
Changed in curtin (Ubuntu): | |
status: | New → Confirmed |
assignee: | nobody → Blake Rouse (blake-rouse) |
Changed in curtin: | |
status: | In Progress → Fix Committed |
Changed in curtin (Ubuntu): | |
status: | Confirmed → Fix Committed |
This bug was fixed in the package curtin - 0.1.0~bzr190- 0ubuntu1
--------------- bzr190- 0ubuntu1) utopic; urgency=medium
curtin (0.1.0~
* New upstream snapshot.
* add log reporter (LP: #1369129, LP: #1371218)
* allow debug messages of helper programs to be seen
* fix 'make check'
* handle utf-8 output correctly. (LP: #1370249)
* set root device correctly on ppc64 (LP: #1371133)
* call update-grub to ensure grub.cfg is written (LP: #1373137)
* fix dd-tgz mode, only call partprobe on target device.
-- Scott Moser <email address hidden> Fri, 26 Sep 2014 17:26:34 -0400