Stop writing useless files.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
CI Train [cu2d] |
Fix Released
|
Undecided
|
Brian Murray |
Bug Description
Ok, so the train is currently experiencing an impedence mismatch of sorts. One part of the code is writing a file to disk, and another part of the code is reading that value back and using it. This was written this way originally because those two parts of the code used to be called a drastically different times, and the files preserved in between.
Currently the files are no longer preserved in between and the value is written then instantly read back. It's pointless and the files should no longer be written to disk.
Start here:
http://
In Archive.
With that gone, "set_file" no longer has any callers and can be removed from here:
http://
(also remove get_file as that already doesn't have any callers)
Then, the next problem you'll have is that you need to access those values from SiloState.
for build in self.builds:
versions[
(same defaultdict magic as the current SiloState.
Manager class has a reference to the SiloState instance so from there it should be easy to pass that value in where it needs to go. Bonus points if you eliminate SiloState.
Just don't forget that "published_
Basically what it boils down to is that the existing SiloState.
Hope that makes sense, if you have any questions I'll be online at 16:00 UTC.
Related branches
- Robert Bruce Park (community): Approve
-
Diff: 255 lines (+38/-64)7 files modifiedcitrain/recipes/base.py (+1/-19)
citrain/recipes/manager.py (+6/-0)
cupstream2distro/archive.py (+1/-1)
cupstream2distro/silomanager.py (+1/-14)
tests/unit/test_recipe_base.py (+1/-9)
tests/unit/test_recipe_manager.py (+26/-0)
tests/unit/test_silomanager.py (+2/-21)
Changed in cupstream2distro: | |
assignee: | nobody → Brian Murray (brian-murray) |
description: | updated |
Changed in cupstream2distro: | |
status: | New → Fix Released |