DotProject class needs to be annihilated.
Bug #1509637 reported by
Robert Bruce Park
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| CI Train [cu2d] |
Fix Released
|
Undecided
|
Robert Bruce Park | ||
Bug Description
I really don't like this class at all, it feels really sloppy compared to the rest of the code.
I did a quick audit of how it's being used and I think it can be merged into BuildBase (eg, nothing outside of BuildBase uses it or references it).
Basically I'm thinking a couple methods on BuildBase could handle reading & writing this data. Also I'd like to transition away from this INI file format and just have the "one file per value" style that's been working so well for me in other places.
Related branches
lp:~robru/cupstream2distro/ditch-dotproject
- Robert Bruce Park (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 877 lines (+110/-379)14 files modifiedcitrain/recipes/base.py (+47/-14)
citrain/recipes/manual.py (+1/-3)
citrain/recipes/merge.py (+1/-3)
citrain/recipes/secondary.py (+0/-4)
citrain/recipes/sourcesync.py (+1/-2)
citrain/revert.py (+1/-2)
cupstream2distro/project.py (+0/-116)
tests/data/project_files/foo.project (+0/-3)
tests/unit/test_project.py (+0/-180)
tests/unit/test_recipe_base.py (+49/-30)
tests/unit/test_recipe_manual.py (+1/-1)
tests/unit/test_recipe_secondary.py (+0/-1)
tests/unit/test_recipe_sourcesync.py (+6/-12)
tests/unit/test_script_revert.py (+3/-8)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in cupstream2distro: | |
| status: | Triaged → Fix Committed |
| Changed in cupstream2distro: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:cupstream2distro at revision None, scheduled for release in cupstream2distro, milestone Unknown