DistributionSourcePackageRelease:+index describes Changed-By as "Uploaded by"

[Steve Langasek]

The latest version of mediascanner2 (https://launchpad.net/ubuntu/+source/mediascanner2/0.107+15.10.20150922.1-0ubuntu1) shows that it was a publication by ci-train-bot sponsoring for jamesh.

jamesh is not an ubuntu-dev, and is not the person who signed off on the packaging changes. That was ken-vandine:

               https://ci-train.ubuntu.com/view/2.%20Publish/job/ubuntu-landing-019-2-publish/101/console

We want launchpad to show the name of the ubuntu-dev who signed off on the package upload into the archive.

It's not clear if this is a cupstream2distro, launchpadlib, or launchpad bug.

[Steve Langasek (vorlon)]

The associated input from jenkins does show the correct launchpad username:
https://ci-train.ubuntu.com/view/2.%20Publish/job/ubuntu-landing-019-2-publish/lastSuccessfulBuild/artifact/packagelist_rsync_ubuntu-landing-019/*view*/

[Robert Bruce Park (robru)]

I contend that this is not a bug in cupstream2distro, because the upload to the archive is done by copy2distro script, here:

http://bazaar.launchpad.net/~cupstream2distro-maintainers/cupstream2distro/trunk/view/head:/copy2distro#L116

This script runs on snakefruit and does not have access to the usual train things. It doesn't have access to any jenkins state at all, just the rsyncfile (which it accesses via rsync) and the PPAs (via launchpadlib). The relevant rsyncfile is here:

https://ci-train.ubuntu.com/view/2.%20Publish/job/ubuntu-landing-019-2-publish/lastSuccessfulBuild/artifact/packagelist_rsync_ubuntu-landing-019/*view*/

Which you can plainly see says "ken-vandine" and does not contain "jamesh" anywhere. So it couldn't possibly have called copyPackage with sponsor='jamesh' because it simply couldn't have known that jamesh had anything to do with anything.

[Steve Langasek (vorlon)]

http://bazaar.launchpad.net/~cupstream2distro-maintainers/cupstream2distro/trunk/view/head:/copy2distro#L125 shows the name of the sponsor being passed to copyPackage. (This is the same thing that syncpackage uses, so it's known to work.)

[Colin Watson (cjwatson)]

This gives a slightly clearer indication of the state of affairs:

In [1]: spph = lp.distributions['ubuntu'].main_archive.getPublishedSources(source_name='mediascanner2', exact_match=True, version='0.107+15.10.20150922.1-0ubuntu1', status='Published')[0]

In [2]: {k: getattr(spph, k) for k in sorted(spph.lp_attributes + spph.lp_entries)}
Out[2]:
{'archive': <archive at https://api.launchpad.net/devel/ubuntu/+archive/primary>,
 'component_name': u'universe',
 'creator': <person at https://api.launchpad.net/devel/~ken-vandine>,
 'date_created': datetime.datetime(2015, 9, 24, 19, 1, 9, 6108, tzinfo=TimeZone(0)),
 'date_made_pending': None,
 'date_published': datetime.datetime(2015, 9, 24, 19, 13, 33, 23556, tzinfo=TimeZone(0)),
 'date_removed': None,
 'date_superseded': None,
 'display_name': u'mediascanner2 0.107+15.10.20150922.1-0ubuntu1 in wily',
 'distro_series': <distro_series at https://api.launchpad.net/devel/ubuntu/wily>,
 'http_etag': u'"0ce408a721d5a8cd8ac4325b049469d0c066967e-29562a94573c717614e7d478ba2b35f0956ba331"',
 'package_creator': <person at https://api.launchpad.net/devel/~jamesh>,
 'package_maintainer': <person at https://api.launchpad.net/devel/~ubuntu-devel-discuss-lists>,
 'package_signer': <person at https://api.launchpad.net/devel/~ci-train-bot>,
 'packageupload': <package_upload at https://api.launchpad.net/devel/ubuntu/wily/+upload/9951896>,
 'pocket': u'Proposed',
 'removal_comment': None,
 'removed_by': None,
 'resource_type_link': u'https://api.launchpad.net/devel/#source_package_publishing_history',
 'scheduled_deletion_date': None,
 'section_name': u'libs',
 'self_link': u'https://api.launchpad.net/devel/ubuntu/+archive/primary/+sourcepub/5408744',
 'source_package_name': u'mediascanner2',
 'source_package_version': u'0.107+15.10.20150922.1-0ubuntu1',
 'sponsor': <person at https://api.launchpad.net/devel/~ubuntu-archive-robot>,
 'status': u'Published'}

We need to arrange for DistributionSourcePackageRelease:+index to have a slightly more sensible rendering of package_creator (~ Changed-By) and creator (~ Signed-By).