Check non-topapproved branches and show on dashboard

Bug #1483684 reported by Timo Jyrinki on 2015-08-11
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Bileto
Wishlist
Unassigned
CI Train [cu2d]
Fix Released
Wishlist
Unassigned

Bug Description

One repetitive and delay causing problem is teams forgetting about top-approving branches, and this showing up only when a trainguard is trying to publish QA approved silo, which is a bit late.

Since trainguards can't keep track on which teams actually utilize the top-approvals, this leads to a delay when waiting for an ack/topapprove from the lander.

This could be improved by having cu2d check the branches status and showing them in Bileto/dashboard.

Timo Jyrinki (timo-jyrinki) wrote :

Mostly like red/green status of whether all MP:s are top-approved or not.

Jean-Baptiste Lallement (jibel) wrote :

To second the OP's description, one repetitive task of the QA team is to check that all the branches have been reviewed and top-approved before starting the verification.
Ideally it should not be possible to set a landing request to 'Ready for QA' if the silo contains branches that have not been top approved.

Robert Bruce Park (robru) wrote :

I'm not sure how you're expecting this to work. The dashboard is javascript which means it doesn't have access to launchpadlib, which is python. In order to get information from launchpadlib, you need to run python, which is currently done by Jenkins, which is why this check happens when you click publish.

If there's a way to poll lp api from javascript I'd love to hear about that, I'm not aware of that possibility unfortunately.

Changed in cupstream2distro:
status: New → Incomplete
Changed in bileto:
status: New → Incomplete
Timo Jyrinki (timo-jyrinki) wrote :

Right, it's not easy at all then.

One option would be jenkins to update some publicly exposed bits every time eg a build job is done (or just periodically similar to migration checks), and then javascript would read those lp api results from jenkins and draw a red dot or green dot depending on whether all MP:s are top-approved or not.

Changed in bileto:
importance: Undecided → Wishlist
Changed in cupstream2distro:
importance: Undecided → Wishlist
Launchpad Janitor (janitor) wrote :

[Expired for CI Train [cu2d] because there has been no activity for 60 days.]

Changed in cupstream2distro:
status: Incomplete → Expired
Launchpad Janitor (janitor) wrote :

[Expired for Bileto because there has been no activity for 60 days.]

Changed in bileto:
status: Incomplete → Expired
Changed in bileto:
status: Expired → Triaged
Changed in cupstream2distro:
status: Expired → Triaged
Robert Bruce Park (robru) wrote :

This is done isn't it? The ticket status will indicate when the merges are in bad states and you can click through to the status log to get the links to the specific MPs that need attention.

Changed in bileto:
status: Triaged → Fix Released
Changed in cupstream2distro:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers