sync logic doesn't mangle versions correctly when syncing within ubuntu

[Robert Bruce Park]

We have a case where systemd-shim has the same version number (but different package contents due to source rebuild) in wily and vivid, due to a train source sync not changing the version number before uploading.

Relevant codepath is here:

http://bazaar.launchpad.net/+branch/cupstream2distro/view/head:/citrain/build.py#L577

Note it only mangles versions when syncing ubuntu->ubuntu-rtm. Needs some logic for syncing ubuntu->ubuntu

[Robert Bruce Park (robru)]

Slangasek wants syncs disabled for non-train-owned packages, which means that SourceSync.collect_phase needs to grow some version-detection to be able to abort syncs if versions don't match train-managed patterns.

[Łukasz Zemczak (sil2100)]

I agree with Steve - in all our documentation I explicitly mentioned that syncs are ONLY for CI Train sources. It should be really easy to do as well as I already do such detection in the change_series() code (using re.match(SERIES_DATE, self.v)). So it's just a matter of extracting that to be used outside, should be a few-line change. I can do it tomorrow morning no problem if you don't mind.

[Robert Bruce Park (robru)]

Yeah I guess change_series should just raise a BuildError and then let that bubble up into the build job which will cancel the build if the version isn't train-managed.

[Robert Bruce Park (robru)]

Er, I mean "change_series should raise a BuildError if the version regex doesn't match", then SourceSync.collect_phase should just let that bubble up, as build.main will already catch that and abort the build.

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:cupstream2distro at revision 991, scheduled for release in cupstream2distro, milestone Unknown