CI Train [cu2d]

oxide-qt fails to produce any diff

Bug #1447314 reported by Robert Bruce Park
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
CI Train [cu2d]
Fix Released
High
Robert Bruce Park

Bug Description

For some reason it is impossible to diff oxide-qt. The full diff comes out as an empty file and there's no packaging diff possible from this. I have no idea why.

See original description

Related branches

lp:~robru/cupstream2distro/no-diffs-in-memory
Robert Bruce Park (community): Approve
PS Jenkins bot: Approve (continuous-integration)
Barry Warsaw: Pending requested
Diff: 961 lines (+448/-360)
15 files modified
cupstream2distro/packagemanager.py (+37/-66)
cupstream2distro/utils.py (+11/-6)
tests/data/diffing/helloworld/.bzr-builddeb/default.conf (+2/-0)
tests/data/diffing/helloworld/debian/changelog (+11/-0)
tests/data/diffing/helloworld/debian/control (+20/-0)
tests/data/diffing/helloworld/debian/rules (+5/-0)
tests/data/diffing/helloworld/hello.sh (+1/-0)
tests/data/diffing/helloworld_0.1+15.10.20150928-0ubuntu1.dsc (+31/-0)
tests/data/diffing/helloworld_0.1+15.10.20150928-0ubuntu1_source.build (+44/-0)
tests/data/diffing/helloworld_0.1+15.10.20150928-0ubuntu1_source.changes (+40/-0)
tests/data/diffing/helloworld_0.1+15.10.20150929-0ubuntu1.dsc (+32/-0)
tests/data/diffing/helloworld_0.1+15.10.20150929-0ubuntu1_source.build (+43/-0)
tests/data/diffing/helloworld_0.1+15.10.20150929-0ubuntu1_source.changes (+41/-0)
tests/strings.py (+0/-132)
tests/unit/test_packagemanager.py (+130/-156)
lp:~robru/cupstream2distro/do-something-sensible-with-oxide-mess
Robert Bruce Park (community): Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 37 lines (+6/-3)
2 files modified
Makefile (+1/-0)
cupstream2distro/packagemanager.py (+5/-3)
Robert Bruce Park (robru)
Changed in cupstream2distro:
importance: Low → High
Revision history for this message
Robert Bruce Park (robru) wrote :

This increased in priority as it seems we're back to no longer being able to diff oxide, even with sloppy utf8 handling. So the attached branch makes sure to do all diffing exclusively on disk, and in bytes (so at no point is there diff data being loaded into memory and interpreted as utf8, should fix all the issues we've seen).

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:cupstream2distro at revision 1126, scheduled for release in cupstream2distro, milestone Unknown

Changed in cupstream2distro:
status: Triaged → Fix Committed
Robert Bruce Park (robru)
Changed in cupstream2distro:
status: Fix Committed → Fix Released
Revision history for this message
Robert Bruce Park (robru) wrote :

The branch didn't actually solve this issue.

I'm pretty stumped at this point. train literally just shells out to debdiff, and gets back an empty file. I tried downloading the packages locally and debdiff is able to generate a diff between them, it's not even particularly huge.

The only thing I can think of is that my successful local debdiff is wily and the faily train debdiff is trusty so I'm trying a trusty schroot to double-check.

Changed in cupstream2distro:
status: Fix Released → Triaged
Robert Bruce Park (robru)
summary: - Diffs should be handled as bytes, not as utf8.
+ oxide-qt fails to produce any diff
description: updated
Revision history for this message
Robert Bruce Park (robru) wrote :

Nope, debdiff works totally fine in trusty too.

Revision history for this message
Robert Bruce Park (robru) wrote :

Ok, problem was that debdiff diffs in /tmp which was filling up, and then the error was getting swallowed. New branch sets TMPDIR to ~/debdiff which has 10x as much free space, and also changes call() to log_call() so that future errors will be spewed all over the logs.

PS Jenkins bot (ps-jenkins)
Changed in cupstream2distro:
status: Triaged → Fix Committed
Revision history for this message
Robert Bruce Park (robru) wrote :

Awwwwwwwwwwwwwwwwwwwwwwwwwww yiiiiiiiiiissssssssssssssssssssssssssssss

https://ci-train.ubuntu.com/job/ubuntu-landing-021-1-build/188/artifact/oxide-qt_content.diff/*view*/

Changed in cupstream2distro:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.