get_source_package_from_dest sometimes downloads too much.

[Robert Bruce Park]

packagemanager.get_source_package_from_dest seems to in some rare cases download more than one version of a package, despite the fact that we pass in the version we want as an argument.

The extra downloaded dsc file is interfering with debdiff creation as well. For example here:

https://ci-train.ubuntu.com/job/ubuntu-landing-000-1-build/316/console

Contains this wrong line:

+ debdiff ubuntu/qtsystems-opensource-src/qtsystems-opensource-src_5.0~git20141206~44f70d99-0ubuntu1.dsc qtsystems-opensource-src_5.0~git20130712-0ubuntu8.dsc qtsystems-opensource-src_5.0~git20141206~44f70d99-0ubuntu2~vivid1~test1.dsc

There should only be two DSCs being diffed, not three. I traced the issue back to here:

http://bazaar.launchpad.net/~cupstream2distro-maintainers/cupstream2distro/trunk/view/head:/cupstream2distro/packagemanager.py#L316

    for url in sourcepkg.sourceFileUrls():
        filename = unquote(url.split('/')[-1])
        filepath = os_path_join_safe(source_package_download_dir, filename)
        urlretrieve(url, filepath)

I believe this needs a version check before downloading all files returned by sourceFileUrls().

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:cupstream2distro at revision 884, scheduled for release in cupstream2distro, milestone Unknown