Bug found (Bool vs Bool 32)

Bug #669908 reported by monday2000 on 2010-11-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cuneiform for Linux
Undecided
Unassigned

Bug Description

1. cuneiform-linux-1.0.0\cuneiform_src\Kern\cline\sources\src\cpp\clinefunc.cpp

See there the function "Bool CopyData(const void* from, void* to, int size)" . It conflicts with its definition in:

cuneiform-linux-1.0.0\cuneiform_src\Kern\cline\sources\src\h\clinefunc.h:

Bool32 CopyData(const void* from,void* to,int size);

In both places should be either Bool or Bool32.

2. Same thing in another place:

cuneiform-linux-1.0.0\cuneiform_src\Kern\puma\main\dll.cpp

Function: PUMA_FUNC(Bool32) PUMA_Done()

cuneiform-linux-1.0.0\cuneiform_src\Kern\hhh\puma.h

Its definition:
DEC_FUN(Bool, PUMA_Done,())

In both places should be either Bool or Bool32.

My MS VC++ 6 compiler failed to compile cuneiform until I fixed 2 these bugs in the compiled sourcecodes.

Please fix these 2 bugs officially.

Jussi Pakkanen (jpakkane) wrote :

Please attach a patch.

Yury V. Zaytsev (zyv) wrote :

Use diff -Naur a b > c.patch .

Jussi Pakkanen (jpakkane) wrote :

Or, even better, bzr diff.

monday2000 (monday2000) wrote :

Sorry, I am under Windows. Never dealt with Linux. Here is the manual description:

1. cuneiform-linux-1.0.0\cuneiform_src\Kern\cline\sources\src\cpp\clinefunc.cpp line 97

was:

Bool CopyData(const void* from, void* to, int size) {

is now:

Bool32 CopyData(const void* from, void* to, int size) {

2. cuneiform-linux-1.0.0\cuneiform_src\Kern\hhh\puma.h line 238

was:

DEC_FUN(Bool, PUMA_Done,())

is now:

DEC_FUN(Bool32, PUMA_Done,())

monday2000 (monday2000) wrote :

I am sorry, but it's probably not worth to me to download http://gnuwin32.sourceforge.net/packages/diffutils.htm and learn it besides - just fot such elementary bug (one-line of text).

It is unclear (the bug) the way I described it? I hope it's clear enough - in a good way. So that you - the main contributors - can already understand clearly what the bug is (without much effort).

Please don't forget to fix this bug - otherwise sources do not compile under Windows.

Yury V. Zaytsev (zyv) wrote :

It's up to you but no sane person will accept a patch that is bigger than 2 lines without a diff.

monday2000 (monday2000) wrote :

I'd say "that depends". :) In such big projects like this one - where patches are so frequent and numerous - yes.

But in small projects where the new bugs are found 2-3 times per month - even the manual bug report form is acceptable.

Of course, if some bug is to take more than 2 lines of text - I will surely use the diff tool. ;)

Good luck with your work.

monday2000 (monday2000) wrote :

I put online the Windows CuneiForm-Linux v1.0.0 that I compiled in MS VC++ 6.0.

Now it can be discussed on my forum here:

http://www.djvu-scan.ru/forum/index.php?topic=115.0

Here is the download link:

http://djvu-soft0001.nxt.ru/cuneiform_hocr_v1_0_0.rar (23,3 MB)

Mirror:
http://ifolder.ru/20085782

Actually, I want to use it for DjVu OCR purposes.

Changed in cuneiform-linux:
status: New → Fix Committed
Changed in cuneiform-linux:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers