Ratings widget allows stars to be changed even when player doesn't support it

[Mackenan Grassi]

No matter which player is loaded, the ratings widget will allow the user to click to change the rating. For players that don't support any method to change track metadata, this allows CG's display to be out of sync with the player and may mislead users to believe that CG has succeeded in changing the rating within the player. I think any update to the ratings widget (including hover effects) should be locked when the user has a player loaded that won't be able to receive any ratings change.

I think MPRIS has yet to define any method for changing track metadata, so any players that only implement MPRIS should follow this functionality. I've attached a patch that encompasses all these changes.

[Alexandr Grigorcea (cahr-gr)]

your patch fixes the bug by creating a bigger issue, if theme stays the same
after changing from player without rating support to player with rating
support the rating widget will stay not clickable
this may be avoided by reloading the theme every time player changes, but
this will require some other changes
I will not merge this patch for now

On Tue, Jan 11, 2011 at 1:39 AM, Mackenan Grassi
<email address hidden>wrote:

>
> ** Patch added: "ratings-widget.patch"
>
> https://bugs.launchpad.net/bugs/701307/+attachment/1790727/+files/ratings-widget.patch
>
> --
> You received this bug notification because you are a member of Gloobus
> Developers, which is the registrant for CoverGloobus.
> https://bugs.launchpad.net/bugs/701307
>
> Title:
> Ratings widget allows stars to be changed even when player doesn't support
> it
>
> Status in CoverGloobus:
> New
>
> Bug description:
> No matter which player is loaded, the ratings widget will allow the user
> to click to change the rating. For players that don't support any method to
> change track metadata, this allows CG's display to be out of sync with the
> player and may mislead users to believe that CG has succeeded in changing
> the rating within the player. I think any update to the ratings widget
> (including hover effects) should be locked when the user has a player loaded
> that won't be able to receive any ratings change.
>
> I think MPRIS has yet to define any method for changing track metadata, so
> any players that only implement MPRIS should follow this functionality. I've
> attached a patch that encompasses all these changes.
>
>
>

[Mackenan Grassi (mackenan)]

True, the patch was simply a quick hack to illustrate the kind of functionality I was talking about. I just thought it would allows the UI to make a bit more sense.

[Mackenan Grassi (mackenan)]

Ok, here's a more complete patch that allows the rating widget to re-evaluate whether it should be clickable each time the player is changed. I also made sure that all players that had a set_rating function also had 'rating' listed in their capabilities.

[Alexandr Grigorcea (cahr-gr)]

thanks,
sorry for long wait