Try to limit the number of extensions warning validation test

Bug #1427397 reported by Yvon TANGUY
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cookiekeeper
Fix Released
Low
Yvon TANGUY

Bug Description

Tests des extensions
0 errors, 7 warnings, 0 notices
`addObserver` called in potentially dangerous manner

Warning: Authors of bootstrapped add-ons must take care to remove any added observers at shutdown.
chrome/content/prefs.permissions.js
        os.notifyObservers(null, NOTIFICATION_FLUSH_PERMISSIONS, PERMISSION_TYPE);
        os.addObserver(this, "perm-changed", false);
                `setSubstitution` called in potentially dangerous manner

Warning: Authors of bootstrapped add-ons must take care to clean up any added resource substitutions at shutdown.
lib/main.js
        resource.setSubstitution(CK_RESOURCE_ALIAS, alias);
SQL statements should be static strings

Warning: Dynamic SQL statement should be constucted via static strings, in combination with dynamic parameter binding via Sqlite.jsm wrappers (http://mzl.la/sqlite-jsm) or `createAsyncStatement` (https://developer.mozilla.org/en-US/docs/Storage#Binding_parameters)
chrome/content/ck.private.js
        if (connection.connectionReady) {
          connection.executeSimpleSQL("DELETE FROM " + DOM_DB_TABLE);
        }
Synchronous SQL should not be used

Warning: The use of synchronous SQL via the storage system leads to severe responsiveness issues, and should be avoided at all costs. Please use asynchronous SQL via Sqlite.jsm (http://mzl.la/sqlite-jsm) or the `executeAsync` method, or otherwise switch to a simpler database such as JSON files or IndexedDB.
chrome/content/ck.private.js
        if (connection.connectionReady) {
          connection.executeSimpleSQL("DELETE FROM " + DOM_DB_TABLE);
        }
SQL statements should be static strings

Warning: Dynamic SQL statement should be constucted via static strings, in combination with dynamic parameter binding via Sqlite.jsm wrappers (http://mzl.la/sqlite-jsm) or `createAsyncStatement` (https://developer.mozilla.org/en-US/docs/Storage#Binding_parameters)
chrome/content/ck.private.js
        if (connection.connectionReady) {
          let stmt = connection.createStatement(delQuery);
Access to the `execute` global

Warning: The use of synchronous SQL via the storage system leads to severe responsiveness issues, and should be avoided at all costs. Please use asynchronous SQL via Sqlite.jsm (http://mzl.la/sqlite-jsm) or the `executeAsync` method, or otherwise switch to a simpler database such as JSON files or IndexedDB.
chrome/content/ck.private.js
        stmt.execute();
        stmt.finalize();
`loadAndRegisterSheet` called in potentially dangerous manner

Warning: Authors of bootstrapped add-ons must take care to unregister registered stylesheets at shutdown.
lib/ui.js
        ssService.loadAndRegisterSheet(this._uriCSS, this._cssType);

Tests de compatibilité
0 errors, 3 warnings, 0 notices
Removed labels in use.

Warning: Some string matched the pattern `itemCookies\.label`, which has been flagged as having been removed or renamed in Thunderbird 31.

See bug https://bugzil.la/953426 for more information.
chrome/content/prefs.firefox.xul
        accessibleType="1003"
        label="&itemCookies.label;"
        accesskey="&itemCookies.accesskey;"
Removed labels in use.

Warning: Some string matched the pattern `itemCookies\.label`, which has been flagged as having been removed or renamed in Thunderbird 31.

See bug https://bugzil.la/953426 for more information.
chrome/content/prefs.seamonkey.xul
        accessibleType="1003"
        label="&itemCookies.label;"
        accesskey="&itemCookies.accesskey;"
Removed labels in use.

Warning: Some string matched the pattern `dateformat`, which has been flagged as having been removed or renamed in Thunderbird 29.

See bug https://bugzil.la/544315 for more information.
chrome/content/common.js
        var gCommon = {
          _sDateFormat : Cc["@mozilla.org/intl/scriptabledateformat;1"].getService(Ci.nsIScriptableDateFormat),
          _eTLDService : Cc["@mozilla.org/network/effective-

Tags: amo

Related branches

Yvon TANGUY (vono22)
Changed in cookiekeeper:
status: Triaged → In Progress
Yvon TANGUY (vono22)
Changed in cookiekeeper:
status: In Progress → Fix Committed
Yvon TANGUY (vono22)
Changed in cookiekeeper:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.