convoy should assist in getting decent caching to the browser
Bug #966253 reported by
Richard Harding
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Convoy |
Triaged
|
Low
|
Unassigned |
Bug Description
In testing out convoy behind an nginx server, I had a hard time getting the browser to cache it. It shows up as a dynamic page and doesn't hit your normal static routes. Setting the cache expires headers eventually took, but nginx can't get tell if the response has changed because convoy isn't setting a last-modified header.
Convoy should set a last-modified header that the web server could then use to help in caching at it's level and to the browser.
Related branches
lp:~rharding/convoy/add_listmod_header
Ready for review
for merging
into
lp:convoy
- No reviews requested
-
Diff: 304 lines (+140/-32)2 files modifiedconvoy/combo.py (+34/-9)
convoy/tests/test_combo.py (+106/-23)
To post a comment you must log in.
In MP https:/ /code.launchpad .net/~rharding/ convoy/ add_listmod_ header/ +merge/ 94437 it was brought up that due to issues syncing various front ends, it's actually preferable to provide etag headers that are the hash of the content. This might be another way to go, but it would require changing convoy from being a streaming response to holding the contents in memory in order to calculate the hash of the content.