Content Cache Charm

proxy_cache_background_update and proxy_cache_use_stale_updating enabled by default

Bug #1871259 reported by Haw Loeung
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Content Cache Charm
Fix Released
Wishlist
Haw Loeung

Bug Description

Hi,

Think we need to revisit enabling proxy_cache_background_update and proxy_cache_use_stale_updating enabled by default. It's helpful for large objects and mostly to avoid hammering backends on initial fetch of fresh objects. For sites where most of the content are smaller files, these should be disabled. The question is, should we enable these by default?

Related branches

~hloeung/content-cache-charm:cleanup
Paul Collins: Approve (lgtm)
Canonical IS Reviewers: Pending requested
Diff: 114 lines (+13/-12)
5 files modified
config.yaml (+3/-3)
lib/nginx.py (+3/-3)
reactive/content_cache.py (+3/-2)
tests/unit/test_content_cache.py (+2/-2)
tests/unit/test_nginx.py (+2/-2)
~hloeung/content-cache-charm:master
Stuart Bishop (community): Approve
Canonical IS Reviewers: Pending requested
Diff: 146 lines (+27/-8)
7 files modified
config.yaml (+8/-0)
lib/nginx.py (+8/-1)
reactive/content_cache.py (+2/-1)
tests/unit/files/nginx_config_rendered_test_output-basic_site.txt (+2/-2)
tests/unit/files/nginx_config_rendered_test_output-token_site.txt (+2/-2)
tests/unit/test_content_cache.py (+2/-0)
tests/unit/test_nginx.py (+3/-2)
Haw Loeung (hloeung)
Changed in content-cache-charm:
importance: Undecided → Wishlist
status: New → Triaged
Haw Loeung (hloeung)
Changed in content-cache-charm:
assignee: nobody → Haw Loeung (hloeung)
status: Triaged → In Progress
Revision history for this message
Haw Loeung (hloeung) wrote :

Added 'enable_cache_background_update' to override or disable this. It's still enabled by default though.

Changed in content-cache-charm:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.