Content Cache Charm

make some things such as cache max_size and proxy_cache_min_uses tunable

Bug #1825325 reported by Tom Haddon
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Content Cache Charm
Fix Released
Medium
Haw Loeung

Bug Description

We should make some things such as cache max_size and proxy_cache_min_uses tunable (charm options)

Related branches

~hloeung/content-cache-charm:reduce-complexity
Stuart Bishop (community): Approve
Canonical IS Reviewers: Pending requested
Diff: 145 lines (+30/-41)
4 files modified
lib/nginx.py (+25/-1)
reactive/content_cache.py (+1/-22)
tests/unit/files/nginx_config_rendered_test_output-site3.local.txt (+1/-0)
tests/unit/test_nginx.py (+3/-18)
~hloeung/content-cache-charm:master
Stuart Bishop (community): Approve
Canonical IS Reviewers: Pending requested
Diff: 114 lines (+30/-10)
6 files modified
lib/nginx.py (+13/-0)
reactive/content_cache.py (+5/-1)
templates/nginx_cfg.tmpl (+5/-6)
tests/unit/files/config_test_config.txt (+2/-0)
tests/unit/files/nginx_config_rendered_test_output-site5.txt (+0/-2)
tests/unit/test_nginx.py (+5/-1)
~hloeung/content-cache-charm:master
Joel Sing (community): Approve (+1)
Canonical IS Reviewers: Pending requested
Stuart Bishop: Pending requested
Diff: 15 lines (+3/-1)
1 file modified
config.yaml (+3/-1)
~hloeung/content-cache-charm:master
Joel Sing (community): Approve (+1)
Stuart Bishop (community): Approve
Diff: 15 lines (+3/-1)
1 file modified
config.yaml (+3/-1)
~hloeung/content-cache-charm:master
Joel Sing (community): Approve (+1)
Haw Loeung: Needs Resubmitting
Canonical IS Reviewers: Pending requested
Diff: 150 lines (+70/-4)
6 files modified
config.yaml (+10/-0)
lib/nginx.py (+3/-1)
reactive/content_cache.py (+2/-0)
templates/nginx_cfg.tmpl (+1/-1)
tests/unit/test_content_cache.py (+52/-2)
tests/unit/test_nginx.py (+2/-0)
Revision history for this message
Haw Loeung (hloeung) wrote :

Automatically determine the cache max_size if none provided (something like 70-75% of total disk size since the nrpe charm is configured to alert at 80% by default).

Changed in content-cache-charm:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Haw Loeung (hloeung) wrote :

So here's what I have planned for this:

- firstly, land a small change to allow overriding cache max_size as a charm config option.

- update charm to allow auto-calculating cache max_size if none given, or set to 0.

- update charm to expose an other/additional proxy_cache_path config option, this will cover proxy_cache_min_uses if the user requires as well as others.

Changed in content-cache-charm:
assignee: nobody → Haw Loeung (hloeung)
Revision history for this message
Barry Price (barryprice) wrote :

> firstly, land a small change to allow overriding cache max_size as a charm config option.

Just for the record, this one change has been merged via the above, and is now in the latest stable release as "cache_max_size" (default 1GB).

This bug can remain open to track the other features.

Haw Loeung (hloeung)
Changed in content-cache-charm:
status: Triaged → In Progress
Haw Loeung (hloeung)
Changed in content-cache-charm:
status: In Progress → Won't Fix
status: Won't Fix → Fix Committed
Haw Loeung (hloeung)
Changed in content-cache-charm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.