logrotate broken if the "log-archive" group doesn't exist

[Junien F]

Hi,

The charm installs the following logrotate file :

/var/log/container-log-archive.log {
    rotate 7
    daily
    dateext
    compress
    notifempty
    missingok
    create 0664 root log-archive
}

The "log-archive" group is hardcoded. But on a lot of machines (e.g. cloud mirrors) it doesn't exist, so logrotate fails with :

/etc/cron.daily/logrotate:
error: container-log-archive:11 unknown group 'log-archive'
error: found error in /var/log/container-log-archive.log , skipping

and the file isn't rotated.

We know this group can possibly not exist on the machine as per https://code.launchpad.net/~hloeung/container-log-archive-charm/+git/container-log-archive-charm/+merge/389938 but it looks like we missed the logrotate config. I guess the fix here is to check if the group exists, and if it doesn't, just use root.

Thanks !

[Haw Loeung (hloeung)]

Should be a matter of converting the logrotate file used to a template and then passing through the right group - 'log-archive' if it exists and 'root' if not (basically what Junien said).

[Haw Loeung (hloeung)]

This looks like fallout from https://code.launchpad.net/~tcuthbert/container-log-archive-charm/+git/container-log-archive-charm/+merge/388283